Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): update stdio options to capture error output #698

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix(cli): update stdio options to capture error output #698

merged 2 commits into from
Dec 4, 2024

Conversation

gronxb
Copy link
Contributor

@gronxb gronxb commented Nov 22, 2024 •
edited
Loading

Summary

If an error occurs, it is not printed in the CLI.

  • as-is:
image
  • to-be:
image

Test plan

  1. react-native-config.js file:
test // That code will cause an error.
  1. yarn prepare

@satya164 satya164 requested a review from atlj November 28, 2024 14:03
satya164
satya164 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@satya164 satya164 merged commit 78f16fc into callstack:main Dec 4, 2024
20 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satya164 satya164 satya164 approved these changes

@atlj atlj Awaiting requested review from atlj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gronxb @satya164