Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: every created example app is testing app #684

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

atlj
Copy link
Collaborator

@atlj atlj commented Nov 15, 2024

Summary

We aren't properly injecting the single-choice questions into our answers yet, and as a result the default example app was testing app. Addressed that problem

Test plan

  1. Create a new library
  2. Make sure the example app is a vanilla testing app

@atlj atlj enabled auto-merge November 15, 2024 13:46
@atlj atlj disabled auto-merge November 15, 2024 19:19
@atlj atlj merged commit 4a3d2a1 into main Nov 15, 2024
20 of 29 checks passed
@atlj atlj deleted the @atlj/every-example-app-is-testing-app branch November 15, 2024 19:19
@atlj
Copy link
Collaborator Author

atlj commented Nov 15, 2024

Fixes #676

@atlj atlj mentioned this pull request Nov 15, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant