Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide select example question when creating local library #594

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix: hide select example question when creating local library #594

merged 1 commit into from
Jul 22, 2024

Conversation

szymonrybczak
Copy link
Contributor

Summary

A regression introduced in #572.

CRNL shouldn't ask for example type in local library scenario.

Test plan

  1. Run create-react-native-library under a React Native project.
  2. Example project shouldn't be included in the local library.

@szymonrybczak szymonrybczak requested a review from satya164 July 22, 2024 12:40
@szymonrybczak szymonrybczak changed the title fix: hide select example question in local library fix: hide select example question when creating local library Jul 22, 2024
satya164
satya164 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@satya164 satya164 added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit ac95039 Jul 22, 2024
32 checks passed
@satya164 satya164 deleted the fix/hide-example-prompt-in-local-library branch July 22, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satya164 satya164 satya164 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szymonrybczak @satya164