Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainership #2

Open
Sytten opened this issue Nov 18, 2024 · 5 comments
Open

Maintainership #2

Sytten opened this issue Nov 18, 2024 · 5 comments

Comments

@Sytten
Copy link

Sytten commented Nov 18, 2024

Hi @cagataycivici,

We rely a lot on the passthrough system because we have a unique setup.
This means we have to find a way to maintain this theme one way or another.
My suggestion would be to create a primefaces-community and put those theme there.
That would allow you to give us editor control over that repository and make it clear this is community lead.

We could also explore generating those passthrough from the css files, it is likely a PITA with the import and all but it doesnt seem impossible to me.

Anyway the discussion is started!

@timothymarois
Copy link

This repo needs something because we rely on this and I find so many issues in the presets we're using working to get fixed ourselves. It would be nice that these presets are also being updated to reflect real improvements rather than everyone trying to hack these styles. (and talking more about functionality-sake, less on design which is app specific).

@Sytten
Copy link
Author

Sytten commented Dec 11, 2024

@cagataycivici any comment?

@Blackskyliner
Copy link

Blackskyliner commented Dec 12, 2024

But what is the scope here for the "unstyled"?

Community based migration work to support the possible myriads of available themes (i mean the normal primevue is already up to 4) with Tailwind as class layer and settings/variables/themes? Which seemed to be the previous attempt which also seems to not be maintainable (time-wise).

Or should the community just build and maintain ONE base-case where people could fork off from within their projects and needs? What is actually what all of us do by importing the preset into our own code and adjust as needed...

As I use the unstyled mode mainly for projects where I know I will want to style based on an existing corporate identity or given style guide, where I do not need any opinionated base design. I just need the availability of a base design which reflects the functions and states of a component. Otherwise I just go with the themed mode and mixin tailwind classes as needed.

Maybe a general use case survey beforehand could conclude that its better to put work into a more functional base layer (as @timothymarois seemed to propse) is the way to go forward for tailwind support.

@Sytten
Copy link
Author

Sytten commented Dec 12, 2024

@Blackskyliner If you want to style yourself, that will be a lot of work to create and maintain.
You might be confusing a couple of things, this repo is the older passthrough method instead of the @apply method.
Most people don't need that, they can stay on the officially maintained theme.
But some of us need to maintain that passthrough method and most of us already have made improvements in our respective fork.
The goal is to pool effort to continue maintaining it.

@Blackskyliner
Copy link

I also meant the passthrough mode, but maybe I used it for the wrong reasons in the past.

I referred to the old theme exporter where you could export the Aura or Lara theme for tailwindcss unstyled-PT mode. Which files are now part of this repository. Which i referred to as maintaining additional/available styles int the future for this unstyled-PT mode. Which is in fact a good base-starter style for the components don't get me wrong.

I also think the PT Mode is not very upgrade friendly as I experienced from v3 to v4 if you already have had many changes to your specific application in the PT-theme. But maybe also my misunderstanding when and how to use it...

But I get that merging already existing effort into one repository may benefit all if the changes are not application specific and apply to everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants