reuse previously created metric scope

cadence-workflow · Dec 11, 2024 · 0e68040 · 0e68040
1 parent acf39b3
commit 0e68040
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/common/metrics/defs.go b/common/metrics/defs.go
@@ -1299,8 +1299,6 @@ const (
 	ReplicationTaskCleanupScope
 	// ReplicationDLQStatsScope is scope used by all metrics emitted related to replication DLQ
 	ReplicationDLQStatsScope
-	// ReplicationMessageTooLargeScope is scope used by all metrics emitted related to replication message size
-	ReplicationMessageTooLargeScope
 	// FailoverMarkerScope is scope used by all metrics emitted related to failover marker
 	FailoverMarkerScope
 	// HistoryReplicationV2TaskScope is the scope used by history task replication processing

diff --git a/service/history/handler/handler.go b/service/history/handler/handler.go
@@ -1555,7 +1555,7 @@ func (h *handlerImpl) GetReplicationMessages(
 
 	h.GetLogger().Debug("Received GetReplicationMessages call.")
 
-	_, sw := h.startRequestProfile(ctx, metrics.HistoryGetReplicationMessagesScope)
+	metricsScope, sw := h.startRequestProfile(ctx, metrics.HistoryGetReplicationMessagesScope)
 	defer sw.Stop()
 
 	if h.isShuttingDown() {
@@ -1601,7 +1601,7 @@ func (h *handlerImpl) GetReplicationMessages(
 
 		size := proto.FromReplicationMessages(tasks).Size()
 		if (responseSize + size) >= maxResponseSize {
-			metricsScope := h.GetMetricsClient().Scope(metrics.ReplicationMessageTooLargeScope, metrics.ShardIDTag(int(shardID)))
+			metricsScope.Tagged(metrics.ShardIDTag(int(shardID)))
 			metricsScope.IncCounter(metrics.ReplicationMessageTooLargePerShard)
 
 			// Log shards that did not fit for debugging purposes