Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart Corrector::match #99

Open
dbaltas opened this issue Feb 7, 2017 · 1 comment
Open

smart Corrector::match #99

dbaltas opened this issue Feb 7, 2017 · 1 comment

Comments

@dbaltas
Copy link

dbaltas commented Feb 7, 2017

The current implementation of Corrector::match currently used in HelpCommand::execute is quite naive since it is only based on php's native similar_text.

Consider making it smarter.

The idea occurred after

$ phpbrew uninstall php-7.0.15
Did you mean 'install'? [Y/n]

Where one presses Yes (or at least I did) without second thought.

I would expect Corrector::match to say "Did you mean 'remove'? [Y/n]".

If this is a direction you would like to go towards, I would be happy to provide a first implementation.

@c9s
Copy link
Owner

c9s commented Feb 7, 2017

Sure! If you have any plan can improve this, any implementation is welcomed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants