Wrong file extension for SimpleTarget<File> #902
Comments
|
Glide
.with(this)
.load(uri)
.asBitmap()
.toBytes(CompressFormat.JPEG, 80) // you have to pick a format with this solution
.format(DecodeFormat.PREFER_ARGB_8888)
.atMost()
.override(MAX_IMAGE_SIZE, MAX_IMAGE_SIZE)
.diskCacheStrategy(DiskCacheStrategy.NONE)
.skipMemoryCache(true)
.into(new SimpleTarget<byte[]>() { |
|
@TWiStErRob I write this code: public static synchronized void saveImage(Context context, String imageUrl) {
Glide.with(context.getApplicationContext())
.load(imageUrl)
.downloadOnly(new SimpleTarget<File>() {
@Override
public void onResourceReady(File src, GlideAnimation<? super File> glideAnimation) {
try {
File dst = new File(APP_GALLERY_IMAGE_PATH + "/" + src.getName());
if(!dst.mkdirs()) {
throw new IOException("");
}
InputStream in = new FileInputStream(src);
OutputStream out = new FileOutputStream(dst);
// Transfer bytes from in to out
byte[] buf = new byte[1024];
int len;
while ((len = in.read(buf)) > 0) {
out.write(buf, 0, len);
}
in.close();
out.close();
} catch (IOException e) {
e.printStackTrace();
}
}
});
}but I also get wrong extension. also the created thing is directory not File. and is 0KB |
|
Java does what you ask it to do. You create a folder with the name of the file Glide has given you. To ensure that the folder is ready to receive new files: File gallery = new File(APP_GALLERY_IMAGE_PATH);
if (!gallery.mkdirs() && (!gallery.exists() || !gallery.isDirectory())) {
throw new IOException("Invalid gallery path: " + gallery);
}then, to create a file with a meaningful name either: String ext = android.webkit.MimeTypeMap.getFileExtensionFromUrl(imageUrl);
File dst = new File(gallery, src.getName() + "." + ext);to get the extension from the original url, but use the cache hash file name; or String name = android.webkit.URLUtil.guessFileName(imageUrl, null, null);
File dst = new File(gallery, name);to get the full original name from the url. Also never do I/O on the UI thread, fire up an AsyncTask or some other background thread to save the file from |
|
I use downloadOnly(Target) method. according to documentation I can do it, right? |
|
If the file access is not buffered by FileInputStream you may have 1k reads for a megabyte large file, with bigger buffer you'll have less actual I/O accesses. It should be measured, but I think 4-64k is reasonable, 16 is a good guess. Your downloadOnly usage is correct, but expensive code in |
|
and another thing. the parameter "imageUrl" is something like this |
|
I gave you two options, you can write any code based on top of that to handle edge cases. You know your urls and types of files. It is possible that appending ".jpg" to the name is enough for you, or you can even peek at the first few bytes of the file to determine the type with |
|
I changed my code: public static synchronized void saveImage(Context context, final String imageUrl) {
downloadImage downloadImage = new downloadImage(context, imageUrl);
downloadImage.execute();
}
private static class downloadImage extends AsyncTask<Void, Void, Void>{
private Context context;
private String imageUrl;
public downloadImage(Context context, String imageUrl){
this.context = context;
this.imageUrl = imageUrl;
}
@Override
protected Void doInBackground(Void... params) {
Glide.with(context.getApplicationContext())
.load(imageUrl)
.downloadOnly(new SimpleTarget<File>() {
@Override
public void onResourceReady(File src, GlideAnimation<? super File> glideAnimation) {
try {
File gallery = new File(APP_GALLERY_IMAGE_PATH);
if (!gallery.mkdirs() && (!gallery.exists() || !gallery.isDirectory())) {
throw new IOException("Invalid gallery path: " + APP_GALLERY_IMAGE_PATH);
}
Random random = new Random();
String ext = android.webkit.MimeTypeMap.getFileExtensionFromUrl(imageUrl);
File dst =
new File(gallery,
String.valueOf(random.nextInt()) + ".jpg");
Log.w("saeed", dst.getName());
if(!dst.createNewFile()) {
throw new IOException("");
}
InputStream in = new FileInputStream(src);
OutputStream out = new FileOutputStream(dst);
// Transfer bytes from in to out
byte[] buf = new byte[1024*16];
int len;
while ((len = in.read(buf)) > 0) {
out.write(buf, 0, len);
}
in.close();
out.close();
} catch (IOException e) {
e.printStackTrace();
}
}
});
return null;
}
}in rumtime I get this fatal exception: |
|
The contents of public static synchronized void saveImage(final Context context, final String imageUrl) {
Glide.with(context.getApplicationContext())
.load(imageUrl)
.downloadOnly(new SimpleTarget<File>() {
@Override public void onResourceReady(File src, GlideAnimation<? super File> glideAnimation) {
new GalleryFileSaver(context, imageUrl, src).execute();
}
});
}
private static class GalleryFileSaver extends AsyncTask<Void, Void, File> {
private final Context context;
private final String imageUrl;
private final File src;
public GalleryFileSaver(Context context, String imageUrl, File src) {
this.context = context;
this.imageUrl = imageUrl;
this.src = src;
}
@Override protected File doInBackground(Void... params) {
try {
dst = new File(getGalleryFolder(), getTargetFileName());
copy(new FileInputStream(src), new FileOutputStream(dst));
} catch (IOException e) {
dst = null;
e.printStackTrace();
}
return dst;
}
@Override protected void onPostExecute(File dst) {
String message = dst != null? "Saved file to " + dst : "Failed to save file from " + src;
Toast.makeText(context, message, Toast.LENGTH_LONG).show();
}
private void copy(InputStream in, OutputStream out) throws IOException {
try {
byte[] buf = new byte[1024 * 16];
int len;
while ((len = in.read(buf)) > 0) {
out.write(buf, 0, len);
}
} finally {
try { in.close(); } catch (IOException ignore) { }
try { out.close(); } catch (IOException ignore) { }
}
}
private String getTargetFileName() throws IOException {
Random random = new Random();
String ext = android.webkit.MimeTypeMap.getFileExtensionFromUrl(imageUrl);
String name = String.valueOf(random.nextInt()) + ".jpg";
Log.w("saeed", name);
return name;
}
private File getGalleryFolder() throws IOException {
File gallery = new File(APP_GALLERY_IMAGE_PATH);
if (!gallery.mkdirs() && (!gallery.exists() || !gallery.isDirectory())) {
throw new IOException("Invalid gallery path: " + gallery);
}
return gallery;
}
} |
I'm trying to save file, picked by user. With jpegs everything is ok, but if user picks png or gif image, resulting resource name contains extension .0 instead of .png or .gif
here is the code:
The text was updated successfully, but these errors were encountered: