Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL with semicolon not working. #2583

Closed
axzae opened this issue Nov 9, 2017 · 1 comment
Closed

URL with semicolon not working. #2583

axzae opened this issue Nov 9, 2017 · 1 comment
Labels
Milestone

Comments

@axzae
Copy link

axzae commented Nov 9, 2017

Glide Version: 4.2.0

Issue details / Repro steps / Use case background:
Glide is escaping URL with semicolon. Tried wrapping URL string with URI.parse(), but it doesn't work either.

Example URL:
http://api.met.no/weatherapi/weathericon/1.1/?symbol=9;content_type=image/png

but glide will change it to: http://api.met.no/weatherapi/weathericon/1.1/?symbol=4%3Bcontent_type=image/png

Thread in StackOverflow:
https://stackoverflow.com/questions/47076398/glide-android-image-library-is-replacing-semicolon-with-3b-in-my-url

@sjudd sjudd added the bug label Nov 9, 2017
@sjudd sjudd added this to the 4.4 milestone Nov 9, 2017
@sjudd
Copy link
Collaborator

sjudd commented Nov 9, 2017

Thanks for reporting this. I believe this is a bug in glide. We should be whitelisting all whitelisted and restricted characters but we're whitelisting only a subset. I have a cl that I believe will fix this which will go into 4.4

@sjudd sjudd closed this as completed in 014bf44 Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants