Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Need for Setuptools and Pip Downgrades #5

Open
Zach-Attach opened this issue Jan 29, 2024 · 2 comments
Open

Remove Need for Setuptools and Pip Downgrades #5

Zach-Attach opened this issue Jan 29, 2024 · 2 comments
Labels
status: blocked Not able to be completed at the moment type: feature New feature or request

Comments

@Zach-Attach
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
As it currently stands, users are required to run pip install setuptools==65.5.0 pip==21 prior to installing. This is a solution, but is fragile and may lead to dependency conflicts in the future. It also makes installation of the package more difficult for users and may force them to be unable to run it with their existing code.

Describe the solution you'd like
According to this comment, the solution is to change gym to gymnasium

  • All references to gym would be replaced by gymnasium
  • Any incompatibilities should be adjusted as specified here
  • The following dependencies would need to be updated:
    • gym==0.21 ->gymnasium
    • stable-baselines3[extra]==1.8.0 -> stable-baselines[extra]==2
    • sb3-contrib==1.8.0 -> sb3_contrib==2
    • git+https://github.com/ir413/mvp -> fork of mvp that uses gymnasium such as (https://github.com/Zach-Attach/mvp)
    • NOTE: parts of mvp uses isaacgym which uses gym==0.21, so this would need to be accounted for
    • mlagents==1.0.0 -> mlagents with gymnasium, although the current dependency is gym>=0.21 so gym==0.27 might work

It might be possible to simply use gym==0.27 instead, but this is unconfirmed and just speculative.

Describe alternatives you've considered

  • Continue to use gym==0.21 until mlagents updates its dependency to gymnasium
  • Update to gym==0.27 if it solves the issue, this would still require dependency updates although the scope of this is not certain. At the very least, mvp would need to be forked and changed to be compatible with gym==0.27
@Zach-Attach Zach-Attach added type: feature New feature or request status: blocked Not able to be completed at the moment labels Jan 29, 2024
@desaibhargav
Copy link
Collaborator

Thanks for the details on this @Zach-Attach, the only clean solution I see is if mlagents bumps support from gym to gymnasium which currently does not look like a priority, see here [https://github.com/Unity-Technologies/ml-agents/issues/5995]

I haven't tested with gym==0.27 yet, please let me know if everything runs successfully for you with that version.

@desaibhargav
Copy link
Collaborator

"Nothing planned for now. MLA is in maintenance mode for now. Minor bug fixes, dependency updates, minor features. We are, however, accepting PRs, so if anyone from the community would like to make this upgrade and submit a PR, that would be amazing." is the latest update from devs at mlagents,

We might consider sending a PR to them for this at some point, so keeping this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked Not able to be completed at the moment type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants