Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put building of ockam_app create behind a feature flag #5977

Open
mrinalwadhwa opened this issue Sep 15, 2023 · 4 comments
Open

Put building of ockam_app create behind a feature flag #5977

mrinalwadhwa opened this issue Sep 15, 2023 · 4 comments

Comments

@mrinalwadhwa
Copy link
Member

mrinalwadhwa commented Sep 15, 2023

Building ockam_app requires specific OS packages
https://github.com/build-trust/ockam/blob/develop/tools/nix/parts/rust.nix#L46-L61 and typescript code.

This hurts the experience of new developers trying to build ockam rust code with cargo build

https://github.com/build-trust/ockam/tree/develop/implementations/rust/ockam/ockam_app
https://github.com/build-trust/ockam/blob/develop/Cargo.toml

cargo build in the root of ockam repo should succeed if a recent version of Rust is installed


We love helping new contributors!
If you have questions or need help as you work on your first Ockam contribution, please leave a comment on this discussion.
If you're looking for other issues to contribute to, checkout this discussion and labels - Good first issue or Help wanted

@mrinalwadhwa
Copy link
Member Author

@davide-baldo This came up in one of our conversations earlier this week. It came up again in a conversion with @adiSuper94 on discord as well.

@adiSuper94
Copy link
Contributor

adiSuper94 commented Sep 15, 2023

For me on ubuntu running, sudo apt install libwebkit2gtk-4.1-dev did the trick.

@adiSuper94
Copy link
Contributor

adiSuper94 commented Sep 26, 2023

@mrinalwadhwa I am not sure if the fix will be a trivial change to the root cargo toml.
rust-lang/cargo#4942 (comment)

PLMK if I am missing some thing.

@mrinalwadhwa
Copy link
Member Author

@adiSuper94 you're right, hmm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants