Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 support #670

Open
kampalex opened this issue Nov 26, 2024 · 2 comments · May be fixed by #671
Open

PHP 8.4 support #670

kampalex opened this issue Nov 26, 2024 · 2 comments · May be fixed by #671
Labels
needs discussion Requires internal analysis/discussion

Comments

@kampalex
Copy link

After upgrading to PHP 8.4.1 some deprecations appear:

Implicitly marking parameter [...] as nullable is deprecated, the explicit nullable type must be used (info)
Failing scenarios: (type) (name) = null
Fix for PHP ^8.0: (type)|null (name) = null
Fix for PHP ^7.1: ?(type) (name) = null
Older PHP versions: remove the (type)

Constant Bugsnag\E_STRICT is deprecated (info)
It seems like the E_STRICT constant is now assumed to be in Bugsnag namespace.

Error disappears when adding next lines of code in src/ErrorTypes.php (but it's a dirty fix):

if (!defined('E_STRICT')) {
    define('E_STRICT', 2048);
}

I didn't discover other scenarios yet. If so, I will extend this issue.

@danepowell danepowell linked a pull request Nov 27, 2024 that will close this issue
@danepowell
Copy link

Took a crack at this: #671

@mclack
Copy link

mclack commented Dec 5, 2024

Hi @kampalex

Thanks for raising this.

As mentioned on the linked PR:

We are currently investigating and discussing support for PHP 8.4 internally, which includes evaluating this PR.

We'll make sure to post any updates here as they become available.

@mclack mclack added the needs discussion Requires internal analysis/discussion label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Requires internal analysis/discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants