-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Enum "in / not_in" in the Map #673
Comments
Hi @yrcs, looking at the rule comparison chart in / not_in is not supported in maps at this stage. If you require them, id be happy to review a PR but at this stage we are focused on bugs and language support parity. |
OK! Just keep this issue open... |
I don't think it's specified in this comparison chart. The chart shows I'd argue that this is a bug, not a lack of a feature, because pgv doesn't ignore |
@haines You're right, it's a bug. And I solved it temporarily by adding the following variables to the generated *.pb.validate.go file. var _PagingRequest_OrderBy_InLookup = map[Order]struct{}{
0: {},
1: {},
} |
@elliotmjackson I have encountered the same problem with IDLs like this one.
The definition of _CreateTextRequest_Texts_InLookup is missing from the generated go code.
Can this issue be fixed? |
Same problem +1 |
Good news! this has since been resolved in our protovalidate project. I'm pleased to let you know that protovalidate is where we're focusing our efforts for the future. Given the improvements and advancements in protovalidate, I recommend considering migration to this newer version. It offers a more comprehensive and user-friendly experience within the Protobuf ecosystem. |
The closed #619 issue is still unresolved.
The text was updated successfully, but these errors were encountered: