fix: 🐛 cloneCSSStyle: copy transformOriginProp #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari `cssText` does not include transform-origin prop
|
💖 Thanks for opening this pull request! 💖 Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
|
Hiya! |
|
👋 @artemtumin Congrats on merging your first pull request! 🎉🎉🎉 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
# [1.10.0](v1.9.0...v1.10.0) (2022-08-11) ### Bug Fixes * 🐛 cloneCSSStyle: copy transformOriginProp ([#297](#297)) ([76b978a](76b978a)) * 🐛 font format could be without qoutation ([#217](#217)) ([2a96149](2a96149)) * 🐛 set selected attribute on option to draw it ([#280](#280)) ([caf97c8](caf97c8)) * 🐛 text breaks on the last word ([#270](#270)) ([062c98a](062c98a)) * test specs ([c7a664e](c7a664e)) ### Features * ✨ add 'fetchRequestInit' option ([#210](#210)) ([c51da3a](c51da3a)) * ✨ added includeQueryParams flag ([#260](#260)) ([259d71e](259d71e))
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi @artemtumin , I too encountered a similar issue. I tried with recent version 1.10.4. But it didn't supported. Am I missing something here?? |
|
Hi @harshiniravula! Sorry for the delayed answer. I checked version 1.10.8 and it's working for safari now, but it still doesn't work for iOS Safary. There should be another solution connected with copyCSS function |
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
Safari `cssText` does not include transform-origin prop
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a)) * 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149)) * 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8)) * 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a)) * test specs ([c7a664e](bubkoo@c7a664e)) * ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a)) * ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
Safari `cssText` does not include transform-origin prop
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a)) * 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149)) * 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8)) * 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a)) * test specs ([c7a664e](bubkoo@c7a664e)) * ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a)) * ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
Safari `cssText` does not include transform-origin prop
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a)) * 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149)) * 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8)) * 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a)) * test specs ([c7a664e](bubkoo@c7a664e)) * ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a)) * ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
Safari `cssText` does not include transform-origin prop
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a)) * 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149)) * 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8)) * 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a)) * test specs ([c7a664e](bubkoo@c7a664e)) * ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a)) * ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
Safari `cssText` does not include transform-origin prop
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a)) * 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149)) * 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8)) * 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a)) * test specs ([c7a664e](bubkoo@c7a664e)) * ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a)) * ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari
cssTextdoes not include transform-origin propDescription
The only change was to copy transform-origin prop additionally with copying the cssText from source to target node
Motivation and Context
Problem was described in issue #296
Types of changes
Self Check before Merge