chore(deps): update dependency webpack-dev-middleware to v5 [security] #147

renovate · 2024-08-06T09:44:49Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
webpack-dev-middleware	`3.6.2` -> `5.3.4`

GitHub Vulnerability Alerts

CVE-2024-29180

Summary

The webpack-dev-middleware middleware does not validate the supplied URL address sufficiently before returning the local file. It is possible to access any file on the developer's machine.

Details

The middleware can either work with the physical filesystem when reading the files or it can use a virtualized in-memory memfs filesystem.
If writeToDisk configuration option is set to true, the physical filesystem is used:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/setupOutputFileSystem.js#L21

The getFilenameFromUrl method is used to parse URL and build the local file path.
The public path prefix is stripped from the URL, and the unsecaped path suffix is appended to the outputPath:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/getFilenameFromUrl.js#L82
As the URL is not unescaped and normalized automatically before calling the midlleware, it is possible to use %2e and %2f sequences to perform path traversal attack.

PoC

A blank project can be created containing the following configuration file webpack.config.js:
module.exports = { devServer: { devMiddleware: { writeToDisk: true } } };

When started, it is possible to access any local file, e.g. /etc/passwd:
$ curl localhost:8080/public/..%2f..%2f..%2f..%2f../etc/passwd

root:x:0:0:root:/root:/bin/bash
daemon:x:1:1:daemon:/usr/sbin:/usr/sbin/nologin
bin:x:2:2:bin:/bin:/usr/sbin/nologin
sys:x:3:3:sys:/dev:/usr/sbin/nologin
sync:x:4:65534:sync:/bin:/bin/sync
games:x:5:60:games:/usr/games:/usr/sbin/nologin

Impact

The developers using webpack-dev-server or webpack-dev-middleware are affected by the issue. When the project is started, an attacker might access any file on the developer's machine and exfiltrate the content (e.g. password, configuration files, private source code, ...).

If the development server is listening on a public IP address (or 0.0.0.0), an attacker on the local network can access the local files without any interaction from the victim (direct connection to the port).

If the server allows access from third-party domains (CORS, Allow-Access-Origin: * ), an attacker can send a malicious link to the victim. When visited, the client side script can connect to the local server and exfiltrate the local files.

Recommendation

The URL should be unescaped and normalized before any further processing.

Release Notes

webpack/webpack-dev-middleware (webpack-dev-middleware)

chore(deps): update dependency webpack-dev-middleware to v5 [security] #147

Are you sure you want to change the base?

chore(deps): update dependency webpack-dev-middleware to v5 [security] #147

Conversation

renovate bot commented Aug 6, 2024 • edited Loading

GitHub Vulnerability Alerts

Summary

Details

PoC

Impact

Recommendation

Release Notes

5.3.4 (2024-03-20)

Bug Fixes

Features

5.2.2 (2021-11-17)

Chore

5.2.1 (2021-09-25)

Features

Features

Bug Fixes

⚠ BREAKING CHANGES

Features

Bug Fixes

Features

Features

4.0.4 (2021-01-13)

Bug Fixes

4.0.3 (2021-01-12)

Bug Fixes

4.0.2 (2020-11-10)

Bug Fixes

4.0.1 (2020-11-09)

Bug Fixes

⚠ BREAKING CHANGES

Bug Fixes

3.7.3 (2020-12-15)

Bug Fixes

Features

Configuration

renovate bot commented Aug 6, 2024 •

edited

Loading