Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVD limitations #302

Open
javicid opened this issue Aug 12, 2020 · 0 comments
Open

SVD limitations #302

javicid opened this issue Aug 12, 2020 · 0 comments
Labels
algorithm related Issues that require algorithm understanding enhancement New feature or request hard Complex issues that are not easy to solve

Comments

@javicid
Copy link
Collaborator

javicid commented Aug 12, 2020

The current implementation of SVD has the following limitations:

  • Convergence checking needs to synchronize data (could be improved with exceptions mechanism)
  • Convergence criteria should be revised because it was not completely clear to me how to compute it
  • n_rows needs to be greater than n_cols (this could be solved by implementing a row-wise algorithm or by transposing the ds-array)
  • Uses the simplest pairings for columns, which might not be the best for parallelism (other pairings should be explored)
  • Doesn't work for irregular ds-arrays
  • It might be better to compute V.T instead of V
  • The input array needs at least 2 column blocks (we could use numpy directly or a row-wise algorithm for ds-arrays with one column block)
@javicid javicid added enhancement New feature or request hard Complex issues that are not easy to solve algorithm related Issues that require algorithm understanding labels Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm related Issues that require algorithm understanding enhancement New feature or request hard Complex issues that are not easy to solve
Projects
None yet
Development

No branches or pull requests

1 participant