Issues after 3.0.11 update

[jdsirota]

I have the following section of code in my program, which was working before the update:

var crypto = require('crypto') /* istanbul ignore next */ if (crypto.pbkdf2Sync.toString().indexOf('keylen, digest') === -1) { throw new Error('Unsupported crypto version') }

After updating 3.0.11, pbkdf2Sync is undefined and so my code is failing. Any information on why this may be happening would be greatly appreciated.

[argshook]

hi, you can check #60

[Incanus3]

same issue, tried with 3.0.10 and that's broken as well.

[alirussell]

@Incanus3 i managed to get it working by forcing 3.0.9

[Incanus3]

So did I, after I finally found the source of the problem. At least this will force me to use yarn instead of npm. If I had yarn.lock, I could've found it much sooner.

[danbrianwhite]

The update to add this check completely breaks Webpack since it ultimately utilizes this package for crypto.

[calvinmetcalf]

shoulf be fixed

[danbrianwhite]

Not fixed. The problem is the core functionality in Webpack depends on this code not throwing an error. When the crypto.pbkdf2Sync value is undefined Webpack was OK with that especially if you did not really need to use the pbkdf2 method. Now what happens is there is an error thrown by the browser because crypto.pbkdf2Sync is actually undefined when using Webpack. Even if that did not error out, when the updated code throws an error, the code still breaks running Webpack bundles.

[calvinmetcalf]

@danbrianwhite are you getting an error in version 3.0.12 and if so what is it?

[danbrianwhite]

@calvinmetcalf when crypto is required, it does not have the key pbkdf2Sync. This key is undefined which throws a JS error because the value is undefined. Even if that undefined value is checked for, it will still break Webpack because it expects not to be thrown and the code will now be thrown because of this commit

[calvinmetcalf]

what exactly is your config, that file shouldn't even be loaded in the first place because of the browser field in the package.json

[calvinmetcalf]

that's what #62 fixed

[danbrianwhite]

@calvinmetcalf Thank you for following up with me. The issue is indeed fixed now with v 3.0.12 - it looks like it took a little time to propagate through my cache. Thank you for fixing the issue.

[dcousens]

@calvinmetcalf seems like you had fun overnight.
Everything looks good now?

Anything published/unpublished?

[calvinmetcalf]

I believe it's all fine now

[calvinmetcalf]

basically I forgot to update browser object so it was pointing at the wrong file