Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal refactoring of CLI and test improvements #157

Merged
merged 1 commit into from
Jul 26, 2020

Conversation

browniebroke
Copy link
Owner

This change enables us to test the CLI without patching our own function, to have a test running the whole code path.

@browniebroke browniebroke added the bug Something isn't working label Jul 26, 2020
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 26, 2020

Sourcery Code Quality Report (beta)

❌  Merging this PR will decrease code quality in the affected files by 0.04 out of 10.

Quality metrics Before After Change
Complexity 0.52 0.55 0.03 🔴
Method Length 34.56 36.01 1.45 🔴
Quality 9.11 9.07 -0.04 🔴
Other metrics Before After Change
Lines 350 356 6
Changed files Quality Before Quality After Quality Change
django_codemod/cli.py 8.76 8.66 -0.10 🔴
django_codemod/commands.py 9.50 9.52 0.02 🔵
tests/test_cli.py 9.20 9.12 -0.08 🔴
tests/visitors/base.py 9.66 9.78 0.12 🔵

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!

@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #157   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          548       547    -1     
=========================================
- Hits           548       547    -1     
Impacted Files Coverage Δ
django_codemod/cli.py 100.00% <100.00%> (ø)
django_codemod/commands.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df9fdef...247dccc. Read the comment docs.

@browniebroke browniebroke added tests CI, CD and testing related changes and removed bug Something isn't working labels Jul 26, 2020
@browniebroke browniebroke merged commit 82e666f into master Jul 26, 2020
@browniebroke browniebroke deleted the refactor/build-command branch July 26, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests CI, CD and testing related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant