Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons #9

Closed
fredjens opened this issue Apr 18, 2017 · 1 comment
Closed

Icons #9

fredjens opened this issue Apr 18, 2017 · 1 comment

Comments

@fredjens
Copy link
Contributor

How should we handle icons?

Goal: Super easy to use, but flexible styling.

Options:

  • Inline seperate SVG's
    pros: only loading the icons beeing used / cons: needs to be done in the template.
  • Inline SVG's in hidden div and use href:xlink to load the SVG
    pros: able to set fill: color / cons: all icons are loaded on page load.
  • SVG as background image
    pros: not external dependencies, only loads the SVG's beeing used / cons: not able to set fill: color
  • Using an icon font
    pros: simple to use, can set color: color / cons: not semantic correct (should probably be avoided)...

Any thoughts/preferences on this?

@elisabethirgens
Copy link
Contributor

Any thoughts/preferences on this?

YES!!! So much. 👉 We should use inline SVG in one form or another.

Might be more work upfront to set up, but I really really really think we should invest it that now for a more future friendly flexible fab solution.

Why not use SVG as background image

Boring… We want to be able to style icons with CSS.

Why not use icon fonts?

It’s a hack. SVG is superior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants