Add Visual Studio 2017 builds to AppVeyor

[briansmith]

[Note that Visual Studio “15” is the successor to Visual Studio 2015 and will probably have a different name; see https://www.visualstudio.com/en-us/news/releasenotes/vs15-relnotes.]

Let's support building the C/C++ components with Visual Studio “15” and using its linker.

The AppVeyor issue for Visual Studio “15” support is appveyor/ci#753, where they say they'll wait at least until there's a beta release. But, we'll take patches to support it in ring before then.

[radix]

For reference, it appears that this is now officially called "Visual Studio 2017", and it now has a release candidate available. https://www.visualstudio.com/vs/visual-studio-2017-rc/

[briansmith]

This may blocked on rustc/cargo adding support for VS2017. See rust-lang/rust#38584.

[sanmai-NL]

@briansmith

This may blocked on rustc/cargo adding support for VS2017. See rust-lang/rust#38584.

It seems that issue’s been resolved. Also, I didn’t have problems compiling a crate that uses ring 0.13alpha on an instance of the Windows 10 development VM, which seems to only contain Visual Studio 2017. So it now comes down to modifying the AppVeyor config, right?

[davlia]

Currently still experiencing build issues on Windows 10 using VS 2017 build toolchain

[o0Ignition0o]

Sorry if I'm necrobumping or adding noise to the issue, but I've done a lot of testing today, and it turns out (as advised in the mozilla Building Firefox for Windows page) I'm able to build ring with a Visual Studio 2017 Update 6 (15.6) version, but not with the 15.7 version.

@davlia you might want to try this out, then again, YMMV :)

[trsh]

15.7.4 fails :/

[davlia]

Manage to fix the issue by setting some environment variables set CL="/wd5045". Also verify that your rust triple is correct: x86_64-pc-windows-msvc. @trsh

[trsh]

@davlia your solution is very abstract. Can you provide some insight about the envs etc?

[szczurowski]

On my 15.7.4 the build fails :( Although I set the CL env-var.
BTW: here's a bit info about linker:
:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.14.26428\bin\Hostx64\x64>cl
Microsoft (R) C/C++ Optimizing Compiler Version 19.14.26431 for x64
Copyright (C) Microsoft Corporation. All rights reserved.

[dmitry-vorobiev]

set CL="/wd5045"

Thanks, it helped me))

I ran into the same issue with VS 15.7.5

[briansmith]

Probably not going to add Visual Studio 2017 coverage given 2019 has been out for a while, and due to CI/CD constraints.