Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Wallet overrides MetaMask web3 even when disabled #6053

Closed
shanefontaine opened this issue Sep 17, 2019 · 11 comments
Closed

Brave Wallet overrides MetaMask web3 even when disabled #6053

shanefontaine opened this issue Sep 17, 2019 · 11 comments

Comments

@shanefontaine
Copy link

Description

I am unable to connect to MetaMask when attempting to interact with a contract on remix.ethereum.org.

The MetaMask injected web3 and the Brave injected web3 conflict and I am unable to use MetaMask.

As an aside, when the Brave Browser wallet is enabled, I get redirected to set up a Brave wallet. When the Brave Browser wallet is disabled, I still get redirected, but to a blank page instead.

Steps to Reproduce

  1. Install and unlock MetaMask
  2. Go to https://remix.ethereum.org
  3. Go to the "Deploy and Run Transactions" tab
  4. Change the "Environment" to Injected Web3
  5. Attempt to make a transaction with MetaMask

Actual result:

Unable to connect to MetaMask and send transactions.

Expected result:

Able to connect to MetaMask and send transactions.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

  • Brave Browser Beta
  • Brave: 0.70.93 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
  • Revision: fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{Build failure of missing resources #1035}
  • OS: Mac OS X

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No

  • Does the issue resolve itself when disabling Brave Rewards?
    No

  • Is the issue reproducible on the latest version of Chrome?
    No

Miscellaneous Information:

The console produces the first image when first landing on the site. The console produces the second image after being redirected to brave wallet.

Screen Shot 2019-09-17 at 12 53 22 PM

Screen Shot 2019-09-17 at 12 53 19 PM

@shanefontaine
Copy link
Author

This seems to have been fixed with Version 0.70.97 Chromium: 77.0.3865.65 (Official Build) beta (64-bit).

Closing.

@Bitcoinera
Copy link

Bitcoinera commented Nov 6, 2019

I am getting this same error and I have a newer version than the one you mention: Version 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)

Perhaps it wasn't properly fixed after all?

@nukec
Copy link

nukec commented Nov 12, 2019

Happening here as well as of today.

Version 0.70.123 Chromium: 78.0.3904.97 (Official Build) (64-bit)

@joshstevens19
Copy link

joshstevens19 commented Nov 12, 2019

Happening with me today.

Version 0.70.123 Chromium: 78.0.3904.97 (Official Build) (64-bit)

inpage.js:1 Uncaught Error: MetaMask detected another web3.
     MetaMask will not work reliably with another web3 extension.
     This usually happens if you have two MetaMasks installed,
     or MetaMask and another web3 extension. Please remove one
     and try again.

@PaulRBerg
Copy link

PaulRBerg commented Nov 14, 2019

Yup, can also confirm this error still happens today, on version 0.70.123 Chromium: 78.0.3904.97.

The weird thing is that I'm not getting this error in my default Brave user profile, which I created a while ago. Instead, the error appears when I create a new user, install MetaMask and open a dapp.

Which is weird, because both the default user profile and the new one have the same version of the Brave browser when tapping the "About Brave" menu option + the MetaMask version is the same (7.5.1).

@PaulRBerg
Copy link

Update: so it seems the latest version is actually 1.0.0, not 0.70.123.

Tap the small "Relaunch" button, to the right of the version label printed when tapping "About Brave". This issue with MetaMask should go away after the relaunch.

@drewstaylor
Copy link

I am still having this issue in version 1.0.0

@PaulRBerg
Copy link

PaulRBerg commented Nov 16, 2019

@drewstaylor have you disabled the Brave Wallet? Search for "wallet" in settings and there should be a toggle.

@jderocher
Copy link

For anyone who still has issues, I solved the issue by making sure all of my Brave profiles had the Wallet disabled, then I restarted both Brave and my node dApp which was giving me the multiple wallet console error - that seemed to do the trick for me.

@drewstaylor
Copy link

@drewstaylor have you disabled the Brave Wallet? Search for "wallet" in settings and there should be a toggle.

Thanks @PaulRBerg, I figured it out. I had it disabled but I didn't think to close and re-open Brave :)

@jeremyMG78
Copy link

This is now a problem again. It kept trying to get me to set up the brave wallet. Kinda intruseive. However, by disabling and closing then reopening brave in the instructions above I got it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants