Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScriptHandler fails to install glyphicons in Symfony 2.5 #245

Closed
atosatto opened this issue Jun 5, 2014 · 6 comments
Closed

ScriptHandler fails to install glyphicons in Symfony 2.5 #245

atosatto opened this issue Jun 5, 2014 · 6 comments
Labels

Comments

@atosatto
Copy link

atosatto commented Jun 5, 2014

The ScriptHandler should be updated to support the new location of the Symfony console in Symfony 2.5.

I think is sufficient to update the $appDir variable initialization in the install function.

https://github.com/braincrafted/bootstrap-bundle/blob/develop/Composer/ScriptHandler.php#L33

@florianeckerstorfer
Copy link
Member

Is there a config option I can use that gets me the location of the Symfony console in Symfony < 2.5 and >= 2.5?

@sstok
Copy link

sstok commented Jun 7, 2014

This is how I solved it in the SpBowerBundle.
Spea/SpBowerBundle#86

Use the symfony-bin-dir if it exists, else fall-back to using the 'old' appDir.

Edit. Oops, it should be, use the symfony-bin-dir if it exists (not symfony-app-dir).

@sstok
Copy link

sstok commented Jun 8, 2014

I'll open a PR today to fix this.

@nifr
Copy link
Contributor

nifr commented Jun 8, 2014

@Stok - I was already preparing the PR. :)

@sstok
Copy link

sstok commented Jun 8, 2014

No problem ;)

florianeckerstorfer pushed a commit that referenced this issue Jun 8, 2014
Add symfony-bin-dir (bin/console) support - FIXES: #245,#246.
@florianeckerstorfer
Copy link
Member

Closed by #247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants