update to pass over unavailable leaders #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
edit: context : goal is to be able to continue handling messages and work when a node is down |
|
@ABaldwinHunter I've implemented something similar to this in https://github.com/zendesk/ruby-kafka. The code is still early beta, but I would love it if you would give it a look. |
|
@ABaldwinHunter : Is it supposed to solve the "NotLeaderForPartition" exception? |
|
@adrien-mogenet Yes, this was a stab at that. Has that been fixed in some other way in the intervening months? |
|
Not AFAIK, at least not directly addressed; a reasonable workaround is to use this project instead: |
|
This issue is fixed by https://github.com/zendesk/ruby-kafka. |
|
@dasch Thanks for your work and interest! Apologies, I missed your comment before. Excited to take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@codeclimate/review
This update matches https://github.com/bpot/poseidon/pull/88/files