Nonblocking socket initialisation #79
Conversation
szymonsobczak
changed the title
szymonsobczak
changed the title
szymonsobczak
changed the title
|
This looks great! I would like to have an integration test that reproduces the issue. Have you looked at writing one? It would probably have to be linux only (b/c of |
|
Hi @bpot, I've added the integration test. It requires
The spec fails when connection is using TCPSocket.new() (in my case it takes >30s to timeout) and passes with connect_with_timeout(). Some minor fixes were required to run the suite on OSX, like running OS commands differently and ensuring required dirs exist. I've also worked a bit with sleeps, as the tests were unnecessarily slow and hard to work with. There is still room for improvement - most of the actions can be detected from watching kafka logs, so there should be no need for sleeps whatsoever. BTW, we're using your library on production already for a couple months now and it looks stable, so maybe it's time to release v1.0.0? |
| RSpec.describe "blocked port", :requires => :sudo_pfctl do | ||
| let(:topic) { "test" } | ||
| let(:cluster_metadata) { ClusterMetadata.new } | ||
| let(:message) { MessageToSend.new(topic, "dupa") } |
There was a problem hiding this comment.
@szymonsobczak hey, the content of MessageToSend could be better... ;)
|
is this going to be merged? |
This fixes #78.