Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reopen AddRepoWindow prefilled on failure. #1757

Open
chriscn opened this issue Jul 23, 2023 · 5 comments · May be fixed by #1966
Open

Reopen AddRepoWindow prefilled on failure. #1757

chriscn opened this issue Jul 23, 2023 · 5 comments · May be fixed by #1966
Labels
type:enhancement Improvement of an existing function

Comments

@chriscn
Copy link

chriscn commented Jul 23, 2023

The problem

I ran into several problems when setting up, which I'll describe in a separate issue as it could be a quirk of my installation. However the most frustrating thing was when the repo creation failed it would lose all my repo settings.

I had to reenter my details nine times due to errors, including my path, repo key, and --remote-path=borg1

Requested Solution

Repository settings should be saved, the Start Backup button should be grayed out until that the checks have completed.
@m3nu m3nu added the type:support A question about using vorta label Jul 23, 2023
@m3nu
Copy link
Contributor

m3nu commented Jul 23, 2023

Adding the repo needs to succeed before it's added, since we pull in details like size and archives. We can't have it "half added".

@real-yfprojects
Copy link
Collaborator

Maybe we could reopen the repo add dialog with the same contents when adding the repo fails?

@chriscn
Copy link
Author

chriscn commented Sep 8, 2023

Maybe we could reopen the repo add dialog with the same contents when adding the repo fails?

I think that’s a good idea.

@real-yfprojects real-yfprojects added type:enhancement Improvement of an existing function and removed type:support A question about using vorta labels Sep 12, 2023
@real-yfprojects real-yfprojects changed the title Keep repository settings even on failure Reopen AddRepoWindow prefilled on failure. Sep 12, 2023
@shivansh02
Copy link
Collaborator

Should it be prefilled after vorta is restarted or just for the session?

@shivansh02 shivansh02 linked a pull request Mar 13, 2024 that will close this issue
Draft
9 tasks
@real-yfprojects
Copy link
Collaborator

Should it be prefilled after vorta is restarted or just for the session?

Just for the session imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement Improvement of an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Reopen addrepowindow prefilled when adding repo fails shivansh02/vorta
4 participants
@m3nu @chriscn @real-yfprojects @shivansh02