Upgrade to 2018 Edition

[joshleeb]

With the 2021 edition "coming soon", @bonifaido WDYT of upgrading to the 2018 edition to ease the future switch to the 2021 edition when released?

[bonifaido]

Sorry, I don't really get 🙂

[joshleeb]

My apologies! And forgive me if you're already across this.

This is the Rust edition guide which, TL;DR, talks about how outside of the 6 week release cycle, "editions" are also release every 2 to 3 years.

By default, I believe (based on the guide but could be wrong and in which case will close this issue) that the default edition (if not specified in Cargo.toml) is 2015. Currently the latest is 2018, and in 2021 the plan is to release a new edition.

The edition guide goes into details of what is new/different between the 2015 and 2018 editions. Without going into specific features the areas I'm thinking it will be beneficial to upgrade are

• With a transition to async (Implement async version of the corresponding API methods #5, Remove or replace deprecated mio components #35)
• Encouraging others to contribute as the latest standards/idioms will be used
  • Along with smaller upgrades like replacing try!(<expr>) with <expr>?
• Making it easier to upgrade to the 2021 edition in the future

[joshleeb]

Sorry @bonifaido just bumping the above ☝️ 🙂

Happy to put up a few PRs to get this going but wanting to see if you have any thoughts/preferences before jumping in.