Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VS Code Inlay Hints #1941

Open
modscleo4 opened this issue Sep 3, 2021 · 8 comments
Open

Add support for VS Code Inlay Hints #1941

modscleo4 opened this issue Sep 3, 2021 · 8 comments

Comments

@modscleo4
Copy link

modscleo4 commented Sep 3, 2021

Feature description or problem with existing feature
There is an extension called VS Code Inline Parameters (https://github.com/imliam/vscode-inline-parameters), but it's super slow and CPU heavy. VS Code 1.60 added native support for Inlay Hints (and JS/TS already have it). I didn't find any issue related to Inlay or Inline, so I opened one.

Describe the solution you'd like
In JS/TS, it shows hints for Enums, function return types, parameter names, parameter types, property types and variable types.

Additional context
Screenshot_20210903_113831

@kanlukasz
Copy link

kanlukasz commented Oct 11, 2021

We can call it PARAMETER HINT feature
And yes, it's a great idea. It would be great to have this feature in Intelephense

PS. There is an add-on like https://marketplace.visualstudio.com/items?itemName=robertgr991.php-parameter-hint but at first glance not work properly

@TimWolla
Copy link

TimWolla commented Feb 9, 2022

If I understand it correctly the necessary API within VS Code has been finalized:

microsoft/vscode#16221 (comment)

@modscleo4
Copy link
Author

The Inlay Hint provider API is now finalized on VS Code 1.65

@modscleo4
Copy link
Author

modscleo4 commented Apr 20, 2022

Unfortunately, this needs modifications on the LSP Server, which is (at least I think) closed source. Java people managed to implement inlay hints both on client and server, these are the Pull Requests: https://github.com/eclipse/eclipse.jdt.ls/pull/2019/files https://github.com/redhat-developer/vscode-java/pull/2354/files

I managed to adapt the client, but this will not work without the required modifications in the server https://github.com/modscleo4/vscode-intelephense

@Vincent-HD
Copy link

Any news on this ? This would be a awesome feature to have :D

@opdavies
Copy link

It would be great to see this available in Intelephense now Neovim 0.10 has been released with support for inlay hints.

@TaylorJonesTRT
Copy link

I am also hoping this will be added in! After recently purchasing a license I was disappointed to not see an inlay hint feature for any editor that this can be used in (im using neovim).

@bitbirddev
Copy link

also looking forward for this to be added!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants