Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @mui/icons-material to v6 - autoclosed #1197

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Nov 25, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@mui/icons-material (source) ^5.15.17 -> ^6.0.0 age adoption passing confidence

Release Notes

mui/material-ui (@​mui/icons-material)

v6.1.8

Compare Source

Nov 20, 2024

A big thanks to the 10 contributors who made this release possible.

TODO INSERT HIGHLIGHTS

@mui/[email protected]
@mui/[email protected]
@mui/[email protected]
@mui/[email protected]
Docs
Core

All contributors of this release in alphabetical order: @​DiegoAndai, @​JCQuintas, @​joserodolfofreitas, @​mnajdova, @​oliviertassinari, @​prakhargupta1, @​sai6855, samuelsycamore, @​siriwatknp, @​ZeeshanTamboli

v6.1.7

Compare Source

Nov 13, 2024

A big thanks to the 13 contributors who made this release possible.
This release includes fixes as well as documentation improvements.

@mui/[email protected]
@mui/[email protected]
  • Fix missing @types/hoist-non-react-statics causing styled returns any (#​44397) @​megos
Docs
Core

All contributors of this release in alphabetical order: @​Janpot, @​JCQuintas, @​megos, @​mnajdova, @​navedqb, @​oliviertassinari, @​prakhargupta1, @​sai6855, @​samuelsycamore, @​siriwatknp, @​vladmoroz, @​zanivan, @​ZeeshanTamboli

v6.1.6

Compare Source

Oct 30, 2024

A big thanks to the 13 contributors who made this release possible.

@mui/[email protected]
@mui/[email protected]
@mui/[email protected]
@mui/[email protected]
@mui/[email protected]
Docs
Core

All contributors of this release in alphabetical order: @​aarongarciah, @​blackcow1987, @​DiegoAndai, @​jimmycallin, @​joshkel, @​mnajdova, @​navedqb, @​nphmuller, @​o-alexandrov, @​oliviertassinari, @​prakhargupta1, @​sai6855, @​siriwatknp

v6.1.5

Compare Source

Oct 22, 2024

A big thanks to the 9 contributors who made this release possible.

@mui/[email protected]
@mui/[email protected]
@mui/[email protected]
Docs
Core

All contributors of this release in alphabetical order: @​ChinoUkaegbu, @​Janpot, @​mnajdova, @​oliviertassinari, @​prakhargupta1, @​sai6855, @​samuelsycamore, @​siriwatknp, @​snapwich

v6.1.4

Compare Source

Oct 15, 2024

A big thanks to the 9 contributors who made this release possible.

@mui/[email protected]
Docs
Core

All contributors of this release in alphabetical order: @​aarongarciah, @​bharatkashyap, @​Janpot, @​oliviertassinari, @​prakhargupta1, @​sai6855, @​samuelsycamore, @​siriwatknp, @​zanivan

v6.1.3

Compare Source

Oct 9, 2024

A big thanks to the 18 contributors who made this release possible. Here are some highlights ✨:

  • 🚀 Improved performance on styled components by pre-serializing and caching the styles (#​43412) @​romgrk
@mui/[email protected]
@mui/[email protected]
@mui/[email protected]
@mui/[email protected]
Docs
Core

All contributors of this release in alphabetical order: @​aarongarciah, @​Asin-Junior-Honore, @​barrownicholas, @​Chee7ah, @​effektsvk, @​hieunguyenduc696, @​Janpot, @​Juneezee, @​k-rajat19, @​mnajdova, @​oliviertassinari, @​romgrk, @​sai6855, @​siriwatknp, @​wojtek35, @​yonatan0

v6.1.2

Compare Source

Oct 2, 2024

A big thanks to the 13 contributors who made this release possible.

@mui/[email protected]
Docs
Core

All contributors of this release in alphabetical order: @​albarv340, @​appleSimple, @​BrianWoolfolk, @​DanailH, @​Janpot, @​kdichev, @​oliviertassinari, @​sai6855, @​samuelsycamore, @​siriwatknp, @​wilhelmlofsten, @​yash49, @​ZeeshanTamboli

v6.1.1

Compare Source

Sep 19, 2024

A big thanks to the 18 contributors who made this release possible.

@mui/[email protected]
@mui/[email protected]
@mui/[email protected]
  • Fix "useId" & "useSyncExternalStore" imports to not be statically analyzable (#​43360) @​yash49
Docs
Core

All contributors of this release in alphabetical order: @​aarongarciah, @​binsmyth, @​cherniavskii, @​DiegoAndai, @​Janpot, @​Juneezee, @​LukasTy, @​mnajdova, @​morozow, @​Nashyn, @​oliviertassinari, @​sahil-ag, @​sai6855, @​Sergio16T, @​siriwatknp, @​xconverge, @​yash49, @​ZeeshanTamboli

v6.1.0

Compare Source

Sep 10, 2024

A big thanks to the 21 contributors who made this release possible. Here are the highlights ✨:

  • Minor version changes: To solve longstanding ESM compatibility issues we added package exports to @mui/icons-material (#​43624). This change is backwards compatible with previously recommended setups. Bundlers that don't support the exports field won't be affected. If you discover any issues, please reach out by creating a GitHub issue.
  • This release also includes several fixes and documentation improvements to support the Material UI v6 upgrade.
@mui/[email protected]
@mui/[email protected]
@mui/[email protected]
Docs

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

coderabbitai bot commented Nov 25, 2024

Walkthrough

The pull request involves updates to the package.json file for the client, specifically focusing on the dependencies section. The versions of two Material-UI packages have been upgraded: @mui/icons-material from ^5.15.17 to ^6.0.0, and @mui/material from ^5.16.7 to 6.1.8. No other dependencies or devDependencies have been altered, indicating a targeted upgrade of these specific components.

Changes

File Change Summary
Client/package.json Updated @mui/icons-material from ^5.15.17 to ^6.0.0 and @mui/material from ^5.16.7 to 6.1.8. All other dependencies remain unchanged.

Possibly related PRs


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c4a026b and 78a5313.

⛔ Files ignored due to path filters (1)
  • Client/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • Client/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Client/package.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (1)
Client/package.json (1)

Line range hint 18-23: Hold up! Version mismatch detected! 😰

You've got different major versions running together:

  • v6: @mui/material, @mui/icons-material
  • v5: @mui/lab
  • v7: @mui/x-* packages

This mix could make your arms heavy with compatibility issues!

Consider:

  1. Upgrading @mui/lab to v6 compatible version
  2. Verifying compatibility between v6 core and v7 x-* packages
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between bf79dde and c4a026b.

⛔ Files ignored due to path filters (1)
  • Client/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • Client/package.json (1 hunks)

@@ -14,9 +14,9 @@
"@emotion/react": "^11.13.3",
"@emotion/styled": "^11.13.0",
"@fontsource/roboto": "^5.0.13",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Yo, we got some version mismatches that'll make your knees weak! 🍝

Listen up, there's some serious spaghetti going on with those versions:

  • @mui/lab is still on v5 (^5.0.0-alpha.170) while other MUI core packages are on v6
  • The X components (@mui/x-data-grid and @mui/x-date-pickers) are locked at specific v7 versions
  • Emotion deps look good though, they're compatible with MUI v6

You gotta upgrade that lab package to v6 to keep things consistent, or you might catch some breaking changes that'll make your palms sweaty. Check the compatibility matrix in the migration guide!

🔗 Analysis chain

Vibe check on other dependencies! 🎯

The emotion packages (@emotion/react, @emotion/styled) look good for MUI v6. But yo, make sure to peep the migration guide at mui.com/material-ui/migration-v6/ before merging this!

Let me scope out any potential breaking changes:

Also applies to: 24-35

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any documented breaking changes in dependencies
gh api graphql -f query='
{
  repository(owner: "mui", name: "material-ui") {
    release(tagName: "v6.0.0") {
      description
    }
  }
}'

Length of output: 2458


Script:

#!/bin/bash
# Let's check the current MUI dependencies in package.json
cat Client/package.json | jq '.dependencies | with_entries(select(.key | contains("@mui")))'

# Also check for emotion dependencies
cat Client/package.json | jq '.dependencies | with_entries(select(.key | contains("@emotion")))'

Length of output: 458

@@ -14,9 +14,9 @@
"@emotion/react": "^11.13.3",
"@emotion/styled": "^11.13.0",
"@fontsource/roboto": "^5.0.13",
"@mui/icons-material": "^5.15.17",
"@mui/icons-material": "^6.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

⚠️ Potential issue

Yo dawg, we've got a code emergency! 🍝

Look what's missing from your plate - the required @mui/material-pigment-css dependency! That's a new peer dependency in MUI v6 and it's not in your package.json. Plus, you're mixing MUI versions like mixing different pasta sauces:

  • @mui/material and @mui/icons-material at v6
  • @mui/lab at v5
  • @mui/x-* packages at v7

Found usage of mixed versions in multiple files, including:

  • Client/src/Pages/Settings/index.jsx
  • Client/src/Components/Dialog/index.jsx
  • And 15+ other files using these components

You need to:

  1. Add @mui/material-pigment-css: "^6.0.0" to your dependencies
  2. Consider upgrading @mui/lab to v6 to avoid compatibility spaghetti
  3. Test thoroughly as v6 has breaking changes that might make your code throw up
🔗 Analysis chain

Yo! Major version upgrade alert! 🔥

The jump from v5 to v6 is no joke - it's like mom's spaghetti, you gotta handle it carefully! Here's what's making my palms sweaty:

  1. Breaking changes in v6 need careful migration
  2. Mixed MUI package versions could cause knees weak... I mean, compatibility issues

Let me check those peer dependencies real quick:

Also applies to: 19-19

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check peer dependencies for potential conflicts
curl -s https://registry.npmjs.org/@mui/material/6.0.0 | jq '.peerDependencies'
curl -s https://registry.npmjs.org/@mui/icons-material/6.0.0 | jq '.peerDependencies'

Length of output: 542


Script:

#!/bin/bash
# Let's check the current package.json to see if we have the required peer dependencies
cat Client/package.json | jq '.dependencies | {
  "react": .,
  "react-dom": .,
  "@types/react": .,
  "@emotion/react": .,
  "@emotion/styled": .,
  "@mui/material-pigment-css": .
}'

# Also check for any usage of MUI components to ensure compatibility
rg -l "@mui/(lab|x-charts|x-data-grid|x-date-pickers)" Client/

Length of output: 5641

Copy link

@llamapreview llamapreview bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto Pull Request Review from LlamaPReview

Large PR Notification

Dear contributor,

Thank you for your substantial contribution to this project. LlamaPReview has detected that this Pull Request contains a large volume of changes, which exceeds our current processing capacity.

Details:

  • PR and related contents total size: Approximately 68,390 characters
  • Current limit: 50,000 characters

Next steps:

  1. Consider breaking this PR into smaller, more focused changes if possible.
  2. For manual review, please reach out to your team members or maintainers.

We appreciate your understanding and commitment to improving this project. Your contributions are valuable, and we want to ensure they receive the attention they deserve.

LlamaPReview is continuously evolving to better serve the community. Share your thoughts on handling large PRs in our GitHub Discussions - your feedback helps us improve and expand our capabilities.

If you have any questions or need assistance, our community and support team are here to help.

Best regards,
LlamaPReview Team

@renovate-bot renovate-bot force-pushed the renovate/major-material-ui-monorepo branch from c4a026b to 78a5313 Compare November 26, 2024 03:38
@renovate-bot renovate-bot changed the title Update material-ui monorepo to v6 (major) Update dependency @mui/icons-material to v6 Nov 26, 2024
@renovate-bot renovate-bot changed the title Update dependency @mui/icons-material to v6 Update dependency @mui/icons-material to v6 - autoclosed Nov 26, 2024
@renovate-bot renovate-bot deleted the renovate/major-material-ui-monorepo branch November 26, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant