-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues when content area stretches below the sidebar #1290
Comments
@gorkem-bwl Can you please assign me this task? I'd like to work on it. Thanks! |
Go ahead @RishistavRay - please send as many videos/screenshots as possible with your PR as this is a tricky area :) |
@RishistavRay I don't believe we want scrollability in the sidebar, it should be full window height at all times. @gorkem-bwl can you confirm on this point? |
I was assuming that we can have full height, but the menu is visible at all times. For example if the content area (on the right) have a 2-page length, and the user wants to scroll to the bottom, menu can still be visible. What do you think? |
@gorkem-bwl Yes you can have the menu height cover the entire height of the window (regardless of how long the content page is) The scrollability @ajhollid is mentioning was my suggestion for the case where content area (on the right) is shorter than the minimum height of the left menu to display all items Here, half the menu is inaccessible due to lack of scrolling, but you can scroll the content area on the right. |
Right - got it now :) Your video is very clear and to the point. I think this is what we need to do. Such a small screen is usually for mobile devices and I don't think anyone would see such behaviour on a laptop/desktop. Hence, in case of a mobile device, can you also think of a hamburger menu, so that the content area is larger and we have more space for graphs? |
When the content menu's height is more than the browser window, the sidebar doesn't stretch to the bottom. Under normal conditions (e.g check Settings) the sidebar stretches all the way to the bottom.
This is how it looks for Infra monitor (should be fixed):
This is how it looks for Settings page (the right behaviour):
Also, the "MENU" category name overflows. The sidebar menu should be completely visible regarding the height of the contents area on the right, and MENU category shouldn't overflow.
The text was updated successfully, but these errors were encountered: