Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard navigation #1105

Open
marcelluscaio opened this issue Oct 31, 2024 · 1 comment
Open

Keyboard navigation #1105

marcelluscaio opened this issue Oct 31, 2024 · 1 comment
Assignees
Milestone

Comments

@marcelluscaio
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Some forms in the application are not keyboard navigation friendly. When pressing tab, sometimes we do not have clear indication of where we are, and pressing enter in a form doesn't always trigger submit.

Describe the solution you'd like
We should use semantic HTML in forms (there are some cases where each input is a form. We need:
One form per submit action;
Leverage on submit actions, instead of adding the onClick to buttons;
Buttons with a type of submit within forms;
Focus ring applied when elements have :focus-visible;

@marcelluscaio marcelluscaio self-assigned this Oct 31, 2024
@gorkem-bwl
Copy link
Contributor

Just an addition to this - I have also seen a shortcut for submit / save button, which I liked using. It doesn't require you to use the mouse or trackpad to go to that particular button, and pressing on Cmd-key does the trick. Not 100% related to this issue, but just wanted to point out :)

@gorkem-bwl gorkem-bwl added this to the 2.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants