Fix concurrency error with updating monitor, uncomment out code in pa…

…geSpeedMonitorSlice
bluewave-labs · Oct 28, 2024 · 8730ee9 · 8730ee9
1 parent 86ab22d
commit 8730ee9
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/Server/db/mongo/modules/monitorModule.js b/Server/db/mongo/modules/monitorModule.js
@@ -296,9 +296,12 @@ const getMonitorById = async (monitorId) => {
 		const notifications = await Notification.find({
 			monitorId: monitorId,
 		});
-		monitor.notifications = notifications;
-		const monitorWithNotifications = await monitor.save();
-		return monitorWithNotifications;
+		const updatedMonitor = await Monitor.findByIdAndUpdate(
+			monitorId,
+			{ notifications },
+			{ new: true }
+		).populate("notifications");
+		return updatedMonitor;
 	} catch (error) {
 		error.service = SERVICE_NAME;
 		error.method = "getMonitorById";