Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PSM to OL1 on power-on, LF2 otherwise #15

Open
bluecmd opened this issue Nov 10, 2019 · 5 comments
Open

Set PSM to OL1 on power-on, LF2 otherwise #15

bluecmd opened this issue Nov 10, 2019 · 5 comments
Labels
enhancement New feature or request fc Affects the Fibre Channel part
Milestone

Comments

@bluecmd
Copy link
Owner

bluecmd commented Nov 10, 2019

I don't recall why I chose LF2 as the default state, it seems LF1 would be a more logical choice to avoid having to go LF2 -> LF1 as the initial jump.

@bluecmd
Copy link
Owner Author

bluecmd commented Nov 10, 2019

Is it because it sends NOS maybe? Probably.

@bluecmd bluecmd added the question Further information is requested label Aug 30, 2020
@bluecmd
Copy link
Owner Author

bluecmd commented Sep 9, 2020

An FC_Port shall enter the LF2 State when a Link Failure condition is detected. Upon entry into the LF2
State, the FC_Port shall update the appropriate error counter in the Link Error Status Block (see 22.4.8).
Only one error per Link Failure event shall be recorded. The FC_Port shall remain in the LF2 State while
the condition that caused the Link Failure exists. While in the LF2 State, the FC_Port shall transmit the
NOS Primitive Sequence.
When the Link Failure condition is no longer detected, the FC_Port shall respond to Primitive Sequences
received as defined in table 22.

Seems like the best reset state.

@bluecmd bluecmd closed this as completed Sep 9, 2020
@bluecmd
Copy link
Owner Author

bluecmd commented Sep 9, 2020

Ended up going with OL1 which is the link init state as it is allowed to remain in that state indefinitely. That fix was not cherry-picked. LF2 is the default still.

@bluecmd bluecmd changed the title Switch to STATE_LF1 as default? Set PSM to OL1 on power-on, LF2 otherwise Sep 10, 2020
@bluecmd bluecmd reopened this Sep 10, 2020
@bluecmd
Copy link
Owner Author

bluecmd commented Sep 10, 2020

  • OL1 as state on reset
  • Transition to LF2 if avrx_valid goes low for R_T_TOV, or SFP reports loss of signal.

@bluecmd bluecmd added bug Something isn't working enhancement New feature or request and removed question Further information is requested bug Something isn't working labels Sep 10, 2020
@bluecmd
Copy link
Owner Author

bluecmd commented Sep 10, 2020

It should be possible to re-use the OL1 handling from this dropped patch: rx_state_ol1_handling.txt

@bluecmd bluecmd added the fc Affects the Fibre Channel part label Sep 10, 2020
@bluecmd bluecmd added this to the HBA Alpha milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fc Affects the Fibre Channel part
Projects
None yet
Development

No branches or pull requests

1 participant