Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting a BigDecimal fix version on the 1.1.x series #24

Open
trammel opened this issue Jun 1, 2022 · 0 comments
Open

Requesting a BigDecimal fix version on the 1.1.x series #24

trammel opened this issue Jun 1, 2022 · 0 comments

Comments

@trammel
Copy link

trammel commented Jun 1, 2022

I'm trying to upgrade a codebase to ruby 2.7 (2.6 is EOL), and I'm using this library. I believe it provides real benefit, in quickly and simply defining validation tests, massively reducing the amount of duplicated code that would be necessary to perform the same job, and reducing the risks of tests not being defined or being incomplete.

However, 1.1.1 is not ruby 2.7 compatible, and upgrading to 1.2.x requires an upgrade to dry-validation in to the 1.3 series, that will take weeks of refactoring.

A fix that would buy me a little time is releasing a fix for the BigDecimal problem off the 1.1.x series. I've got a branch, and you can see the changes at https://github.com/bloom-solutions/dry-validation-matchers/compare/v1.1.1...trammel:fix-bigdecimal-legacy-version?expand=1

Could you possibly release a new version of the old 1.1.x series with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant