Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to wrap an existing core? #32

Open
afirth opened this issue Jun 23, 2020 · 0 comments
Open

How to wrap an existing core? #32

afirth opened this issue Jun 23, 2020 · 0 comments

Comments

@afirth
Copy link

afirth commented Jun 23, 2020

For example https://github.com/kubernetes-sigs/controller-runtime/tree/master/pkg/log/zap returns a zap Log with a custom encoder. I can call log.Core() on it, but WrapCore uses the internal core type rather than a zapcore.Core

What I'd like to do is have the controller-runtime log (which is part of kubebuilder among others) wrapped in zapdriver.

Maybe I'm going about this all wrong...

Thanks for the package!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@afirth