Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return margin calls in get_order_book API #1958

Open
3 of 17 tasks
abitmore opened this issue Aug 25, 2019 · 2 comments
Open
3 of 17 tasks

Return margin calls in get_order_book API #1958

abitmore opened this issue Aug 25, 2019 · 2 comments

Comments

@abitmore
Copy link
Member

abitmore commented Aug 25, 2019

User Story
It seems that get_order_book API was designed for retrieving a "combined" order book. It makes sense to add margin calls into the result if price of margin calls is in the range, because traders can place limit orders to buy into the margin calls.

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added this to the Future Feature Release milestone Aug 25, 2019
@pmconrad
Copy link
Contributor

Added DEX + UX impact. UI will want to adapt, e. g. display margin calls in yellow. @SSchiessl

@abitmore
Copy link
Member Author

AFAIK reference UI doesn't use get_order_book API because the result of this API is rounded thus inaccurate, instead, it uses get_limit_orders and get_call_orders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants