Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Request Logging: #73

Merged
merged 1 commit into from
Mar 20, 2015
Merged

Request Logging: #73

merged 1 commit into from
Mar 20, 2015

Conversation

jehiah
Copy link
Member

@jehiah jehiah commented Mar 19, 2015

This improves request logging from

2015/03/19 20:13:41 127.0.0.1:55370 GET /path/

To something closer to Apache Common Log format which includes the Host requested, response code, upstream response timings, etc

<REMOTE_ADDRESS> - <[email protected]> [19/Mar/2015:17:20:19 -0400] <HOST_HEADER> GET <UPSTREAM_HOST> "/path/" HTTP/1.1 "<USER_AGENT>" <RESPONSE_CODE> <RESPONSE_BYTES> <REQUEST_DURATION>

@ploxiln
Copy link
Contributor

ploxiln commented Mar 19, 2015

For nginx, you have to configure it to trust X-Real-IP, since if it's not behind a load balancer, it might be spoofed by the client. Not a huge problem, just thought I'd mention it...

@jehiah
Copy link
Member Author

jehiah commented Mar 20, 2015

@ploxiln true, but since GAP doesn't yet support SSL directly i expect it to always be terminated behind something handling SSL ;-)

Either way i think access logs are much better post this PR

jehiah added a commit that referenced this pull request Mar 20, 2015
@jehiah jehiah merged commit eb67be7 into bitly:master Mar 20, 2015
@jehiah jehiah deleted the logging_73 branch March 20, 2015 03:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants