This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Pass in the original email address too as X-Forwarded-Email. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerhu
force-pushed
the
email
branch
2 times, most recently
from
19211ab to
150c77c
Compare
| @@ -368,6 +368,7 @@ func (p *OauthProxy) ServeHTTP(rw http.ResponseWriter, req *http.Request) { | |||
| if *passBasicAuth { | |||
| req.SetBasicAuth(user, "") | |||
| req.Header["X-Forwarded-User"] = []string{user} | |||
| req.Header["X-Remote-User"] = []string{email} | |||
There was a problem hiding this comment.
What do you think about X-Forwarded-Email?
|
This is a great idea; It makes a lot of sense when allowing auth to more than a single google apps domain. |
|
👍 specifically splunk requires this for us! And that requirement is for x-forwarded-user |
|
@adepue are you saying splunk requires the email address in that field? |
|
@jehiah yep that's exactly it. Splunk Sso integration depends on the full email address in that field. |
rogerhu
changed the title
|
X-Forwarded-Email should be fine. We can reconfigure splunk if needed, as long as the full email comes through. Thanks! |
|
👍 very helpful! |
jehiah
added a commit
that referenced
this pull request
Nov 8, 2014
Pass in the original email address too as X-Forwarded-Email.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need this info to be able to determine whether to login a user on some of our apps.