Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace bdk FeeRate with rust-bitcoin FeeRate #1136

Closed
notmandatory opened this issue Sep 29, 2023 · 3 comments · Fixed by #1216
Closed

Replace bdk FeeRate with rust-bitcoin FeeRate #1136

notmandatory opened this issue Sep 29, 2023 · 3 comments · Fixed by #1216
Labels
good first issue Good for newcomers module-wallet new feature New feature or request
Milestone
1.0.0-alpha

Comments

@notmandatory
Copy link
Member

Describe the enhancement

We should be able to replace the bdk FeeRate struct with the FeeRate from rust-bitcoin since they serve the same purpose and it's less confusing to users to have only one version of the type. Any missing functions from the bdk::FeeRate should be upstreamed to rust-bitcoin or moved to a new bdk trait implemented on rust-bitcoin's FeeRate.

Use case

All existing uses for bdk's FeeRate.

Additional context

https://docs.rs/bitcoin/0.30.1/bitcoin/blockdata/fee_rate/struct.FeeRate.html
https://docs.rs/bdk/1.0.0-alpha.1/bdk/struct.FeeRate.html
@notmandatory notmandatory added the new feature New feature or request label Sep 29, 2023
@notmandatory notmandatory added this to BDK Sep 29, 2023
@notmandatory notmandatory moved this to Todo in BDK Sep 29, 2023
@notmandatory notmandatory added this to the 1.0.0-alpha.3 milestone Sep 29, 2023
@notmandatory notmandatory added the good first issue Good for newcomers label Sep 29, 2023
@danielabrozzoni
Copy link
Member

This is a duplicate of #1037, but since this is way better specified, I'm closing that one and leaving this open instead haha

@danielabrozzoni danielabrozzoni mentioned this issue Sep 29, 2023
Closed
@junderw junderw mentioned this issue Oct 1, 2023
Closed
3 tasks
@nondiremanuel nondiremanuel moved this from Todo to In Progress in BDK Oct 6, 2023
@ValuedMammal ValuedMammal mentioned this issue Nov 15, 2023
Merged
5 tasks
@notmandatory notmandatory modified the milestones: 1.0.0-alpha.3, 1.0.0-alpha.4 Nov 16, 2023
@notmandatory
Copy link
Member Author

We have two PRs working on resolving this issue, #1141 and #1216. I've moved them all to alpha.4 release so everyone has time to review them and we need to decide which one to close.

@nondiremanuel nondiremanuel moved this from In Progress to Needs Review in BDK Dec 2, 2023
@nondiremanuel nondiremanuel modified the milestones: 1.0.0-alpha.4, 1.0.0 Jan 6, 2024
@tnull tnull mentioned this issue Feb 12, 2024
Open
@notmandatory
Copy link
Member Author

A small change but I think we should push to 2.0 milestone.

@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers module-wallet new feature New feature or request
Projects
BDK
Archived in project
Milestone
1.0.0-alpha
3 participants
@notmandatory @danielabrozzoni @nondiremanuel