Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: tests are sometimes failing because a transaction is not yet in a block #386

Closed
codegeschrei opened this issue Apr 5, 2018 · 2 comments
Closed

Problem: tests are sometimes failing because a transaction is not yet in a block #386

codegeschrei opened this issue Apr 5, 2018 · 2 comments

Comments

@codegeschrei
Copy link
Contributor

Solution: change the default mode for sending transactions to commit, to wait for a transaction to be committed to a block
@codegeschrei codegeschrei mentioned this issue Apr 5, 2018
Merged
@future-is-present
Copy link

future-is-present commented Apr 5, 2018 •
edited
Loading

FYI: In the JS Driver for every test we always use the commit mode when sending trasactions

@codegeschrei
Copy link
Contributor Author

We will do it now too. For tests and in general. If people want to have a different mode they have to specify it.

@kansi kansi closed this as completed in #387 Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codegeschrei @future-is-present