You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The MoveList implementation contains a couple of protected static methods that depend on the thread-local reference of the board used as a support for the class itself. Honestly, I don't see any reason to expose the internals to sub-classes and other classes in the same package. I believe they could be "safely" converted to private methods and used only internally as support for the MoveList functionalities: existing integrations of the chesslib library should not make any usage of those methods unless they decided to extend MoveList and access statically a method of the super-class. Please, correct me here if there is a motivation to keep the access visibility as it is at the moment.
The text was updated successfully, but these errors were encountered:
The
MoveList
implementation contains a couple of protected static methods that depend on the thread-local reference of the board used as a support for the class itself. Honestly, I don't see any reason to expose the internals to sub-classes and other classes in the same package. I believe they could be "safely" converted to private methods and used only internally as support for theMoveList
functionalities: existing integrations of thechesslib
library should not make any usage of those methods unless they decided to extendMoveList
and access statically a method of the super-class. Please, correct me here if there is a motivation to keep the access visibility as it is at the moment.The text was updated successfully, but these errors were encountered: