Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the visibility of protected static methods #93

Open
alessandrodalbello opened this issue Jan 5, 2022 · 0 comments
Open

Reduce the visibility of protected static methods #93

alessandrodalbello opened this issue Jan 5, 2022 · 0 comments

Comments

@alessandrodalbello
Copy link
Contributor

The MoveList implementation contains a couple of protected static methods that depend on the thread-local reference of the board used as a support for the class itself. Honestly, I don't see any reason to expose the internals to sub-classes and other classes in the same package. I believe they could be "safely" converted to private methods and used only internally as support for the MoveList functionalities: existing integrations of the chesslib library should not make any usage of those methods unless they decided to extend MoveList and access statically a method of the super-class. Please, correct me here if there is a motivation to keep the access visibility as it is at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant