Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Throughput::Bits or equivilent #630

Open
howardjohn opened this issue Nov 23, 2022 · 0 comments · May be fixed by #833
Open

Add Throughput::Bits or equivilent #630

howardjohn opened this issue Nov 23, 2022 · 0 comments · May be fixed by #833

Comments

@howardjohn
Copy link

This is honestly pretty nitpicky.. but it would be nice to be able to report in Bits instead of Bytes. Its fairly common in networking to report in bits, so I find myself mentally *8ing results quite a bit. It could be nice to have a Throughput::Bits.

one thing I thought of though is to pass Throughput::Bits(bits: usize) may be a bit odd; general bits aren't stored, but bytes. So you would really probably want Throughput::Bits(bytes: usize) which is even more confusing. So I suppose if this was implemented Throughput::Bits(bytesToWrite * 8) would be fairly common which I guess is fine.

(It says a lot about how great criterion is that this is my only complaint 🙂 )

@birneee birneee linked a pull request Dec 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant