Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opprotunistically prune run condition spans #7729

Open
james7132 opened this issue Feb 17, 2023 · 0 comments
Open

Opprotunistically prune run condition spans #7729

james7132 opened this issue Feb 17, 2023 · 0 comments
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible

Comments

@james7132
Copy link
Member

What problem does this solve or what need does it fill?

A span for profiling has non-insignificant overhead (#4892) and a good chunk of run conditions don't take very long to run. The construction of these spans is a few orders of magnitude greater than the time it takes to run the condition itself. This is skewing profiling measurements of the executor when there are a lot of these conditions.

What solution would you like?

Opportunistically avoid making these spans when we know that the time spent in the condition is low.

What alternative(s) have you considered?

  1. Leave it be. Accept the overhead and factor it into our evaluations of performance changes.
  2. Omit them entirely.
  3. Put them behind a feature flag.
@james7132 james7132 added C-Feature A new feature, making something new possible A-ECS Entities, components, systems, and events A-Diagnostics Logging, crash handling, error reporting and performance analysis labels Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible
Projects
None yet
Development

No branches or pull requests

1 participant