Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PipelinedSpriteBundle is not rendered without a texture #3188

Closed
ManevilleF opened this issue Nov 25, 2021 · 0 comments
Closed

PipelinedSpriteBundle is not rendered without a texture #3188

ManevilleF opened this issue Nov 25, 2021 · 0 comments
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use
Milestone

Comments

@ManevilleF
Copy link
Contributor

ManevilleF commented Nov 25, 2021

What problem does this solve or what need does it fill?

The classic SpriteBundle worked with only a ColorMaterial and did not require a sprite texture to be rendered.
The new bundle requires a Handle<Image> to be set.

What solution would you like?

Adding a default dummy square white texture like the classic SpriteBundle

@superdump said:

it probably should default to a 1x1 'dummy' white texture if no texture is present, and use a bit flag in the sprite uniform to indicate whether to sample the texture or not but i don't know if anyone implemented that yet

What alternative(s) have you considered?

There is not really a workaround, I just added a square texture

Additional context

I happened on this issue while attempting to migrate my bevy_life lib to the new renderer (merge request) and the examples did not work without having a custom texture in the assets folder.

@ManevilleF ManevilleF added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Nov 25, 2021
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Nov 26, 2021
@cart cart added this to the Bevy 0.6 milestone Nov 29, 2021
@ManevilleF ManevilleF changed the title PipelinesSpriteBundle is not rendered without a texture PipelinedSpriteBundle is not rendered without a texture Nov 30, 2021
@bors bors bot closed this as completed in a636145 Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
3 participants