From dacdf1c707158159fa6b5574012c3f83f49ed0d7 Mon Sep 17 00:00:00 2001
From: EthanYidong <ethanyidong@gmail.com>
Date: Mon, 21 Sep 2020 13:14:35 -0700
Subject: [PATCH] Rename crate and feature for clarity

---
 Cargo.toml                                                 | 5 +++--
 crates/{bevy_dynload => bevy_dynamic_plugin}/Cargo.toml    | 2 +-
 crates/{bevy_dynload => bevy_dynamic_plugin}/src/lib.rs    | 0
 crates/{bevy_dynload => bevy_dynamic_plugin}/src/loader.rs | 0
 docs/cargo_features.md                                     | 4 ++--
 src/lib.rs                                                 | 4 ++--
 src/prelude.rs                                             | 4 ++--
 tools/publish.sh                                           | 2 +-
 8 files changed, 11 insertions(+), 10 deletions(-)
 rename crates/{bevy_dynload => bevy_dynamic_plugin}/Cargo.toml (95%)
 rename crates/{bevy_dynload => bevy_dynamic_plugin}/src/lib.rs (100%)
 rename crates/{bevy_dynload => bevy_dynamic_plugin}/src/loader.rs (100%)

diff --git a/Cargo.toml b/Cargo.toml
index 618303ef44d702..bb7b766ff1db65 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -22,8 +22,8 @@ default = [
     "bevy_gltf",
     "bevy_wgpu",
     "bevy_winit",
-    "bevy_dynload",
     "render",
+    "dynamic_plugins",
     "png",
     "hdr",
     "mp3",
@@ -31,6 +31,7 @@ default = [
 ]
 profiler = ["bevy_ecs/profiler", "bevy_diagnostic/profiler"]
 wgpu_trace = ["bevy_wgpu/trace"]
+dynamic_plugins = ["bevy_dynamic_plugin"]
 
 # Rendering support
 render = ["bevy_pbr", "bevy_render", "bevy_sprite", "bevy_text", "bevy_ui"]
@@ -75,7 +76,7 @@ bevy_audio = { path = "crates/bevy_audio", optional = true, version = "0.2.1" }
 bevy_gltf = { path = "crates/bevy_gltf", optional = true, version = "0.2.1" }
 bevy_pbr = { path = "crates/bevy_pbr", optional = true, version = "0.2.1" }
 bevy_render = { path = "crates/bevy_render", optional = true, version = "0.2.1" }
-bevy_dynload = { path = "crates/bevy_dynload", optional = true, version = "0.2.1" }
+bevy_dynamic_plugin = { path = "crates/bevy_dynamic_plugin", optional = true, version = "0.2.1" }
 bevy_sprite = { path = "crates/bevy_sprite", optional = true, version = "0.2.1" }
 bevy_text = { path = "crates/bevy_text", optional = true, version = "0.2.1" }
 bevy_ui = { path = "crates/bevy_ui", optional = true, version = "0.2.1" }
diff --git a/crates/bevy_dynload/Cargo.toml b/crates/bevy_dynamic_plugin/Cargo.toml
similarity index 95%
rename from crates/bevy_dynload/Cargo.toml
rename to crates/bevy_dynamic_plugin/Cargo.toml
index 1df4ed7499d672..b46ee9676eefe8 100644
--- a/crates/bevy_dynload/Cargo.toml
+++ b/crates/bevy_dynamic_plugin/Cargo.toml
@@ -1,5 +1,5 @@
 [package]
-name = "bevy_dynload"
+name = "bevy_dynamic_plugin"
 version = "0.2.1"
 authors = [
     "Bevy Contributors <bevyengine@gmail.com>",
diff --git a/crates/bevy_dynload/src/lib.rs b/crates/bevy_dynamic_plugin/src/lib.rs
similarity index 100%
rename from crates/bevy_dynload/src/lib.rs
rename to crates/bevy_dynamic_plugin/src/lib.rs
diff --git a/crates/bevy_dynload/src/loader.rs b/crates/bevy_dynamic_plugin/src/loader.rs
similarity index 100%
rename from crates/bevy_dynload/src/loader.rs
rename to crates/bevy_dynamic_plugin/src/loader.rs
diff --git a/docs/cargo_features.md b/docs/cargo_features.md
index 4d389a63d8f371..441bc41e2bf459 100644
--- a/docs/cargo_features.md
+++ b/docs/cargo_features.md
@@ -21,8 +21,8 @@ Make use of GPU via [WebGPU](https://gpuweb.github.io/gpuweb/) support.
 ### render
 The render pipeline and all render related plugins.
 
-### bevy_dynload
-Allows for dynamic loading of plugins (previously dynamic_plugins)
+### dynamic_plugins
+Plugins for dynamic loading (libloading)
 
 ### png 
 
diff --git a/src/lib.rs b/src/lib.rs
index 282e62ff728f19..42b2ede77920b5 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -82,5 +82,5 @@ pub use bevy_winit as winit;
 #[cfg(feature = "bevy_wgpu")]
 pub use bevy_wgpu as wgpu;
 
-#[cfg(feature = "bevy_dynload")]
-pub use bevy_dynload as dynload;
+#[cfg(feature = "dynamic_plugins")]
+pub use bevy_dynamic_plugin as dynamic_plugin;
diff --git a/src/prelude.rs b/src/prelude.rs
index 3351c9b9ac7952..6a5fe079db0127 100644
--- a/src/prelude.rs
+++ b/src/prelude.rs
@@ -22,5 +22,5 @@ pub use crate::text::prelude::*;
 #[cfg(feature = "bevy_ui")]
 pub use crate::ui::prelude::*;
 
-#[cfg(feature = "bevy_dynload")]
-pub use crate::dynload::*;
+#[cfg(feature = "dynamic_plugins")]
+pub use crate::dynamic_plugin::*;
diff --git a/tools/publish.sh b/tools/publish.sh
index 5d80d471f04d97..220c1d5b4916f9 100644
--- a/tools/publish.sh
+++ b/tools/publish.sh
@@ -8,7 +8,7 @@ crates=(
     bevy_ecs/hecs
     bevy_ecs
     bevy_app
-    bevy_dynload
+    bevy_dynamic_plugin
     bevy_property/bevy_property_derive
     bevy_property
     bevy_type_registry