Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OSD timer #3894

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix OSD timer #3894

merged 1 commit into from
Apr 12, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis added this to the 10.10.0 milestone Apr 12, 2024
@haslinghuis haslinghuis self-assigned this Apr 12, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 12, 2024 •
edited
Loading

✅ Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit abc660c
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/6619063f631b1c0008a3028e
😎 Deploy Preview https://deploy-preview-3894--origin-betaflight-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Linux
Betaflight-Configurator-Android
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

nerdCopter
nerdCopter approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Precision now works properly.

@nerdCopter nerdCopter requested review from asizon and HThuren April 12, 2024 13:00
@haslinghuis haslinghuis merged commit 0acc0e4 into betaflight:master Apr 12, 2024
11 checks passed
@haslinghuis haslinghuis deleted the fix-osd-timer branch April 12, 2024 20:50
@HThuren
Copy link
Member

HThuren commented Apr 13, 2024

I look into why sort mix up the precision, when translate the sort are nice (without the mixup of course)

chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Fix OSD timer (betaflight#3894)
18bd3ff
@haslinghuis haslinghuis mentioned this pull request May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@blckmn blckmn blckmn approved these changes

@asizon asizon Awaiting requested review from asizon

@HThuren HThuren Awaiting requested review from HThuren

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

OSD timer precision mixed up
4 participants
@haslinghuis @HThuren @blckmn @nerdCopter