-
-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the dark / light theme work with PWA #3883
Conversation
✅ Deploy Preview for origin-betaflight-configurator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- tested as working both PWA and NWjs. only quick-tested, did not check every tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bf2491b
to
2baea6c
Compare
This comment has been minimized.
This comment has been minimized.
Changed the way the dark-theme is loaded. Thanks to @vitroid for the suggestion.
2baea6c
to
1d66c58
Compare
@haslinghuis I think I've fixed it now :) |
Quality Gate passedIssues Measures |
Do you want to test this code? Here you have an automated build: |
Changed the way the dark-theme is loaded. Thanks to @vitroid for the suggestion.
Changed the way the dark-theme is loaded. Thanks to @VitroidFPV for the suggestion.
Now the PWA is dark theme only, with this it respects the user preference (light, dark or auto).
The less file shows a lot of changes, but is because it contains one indentation more and it has gone crazy. If you compare ignoring spaces the changes are only this, nothing more:
I've done some tests, but any test more will be appreciated. It must work both, under PWA and under Node.