Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent detection when busy #3745

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Prevent detection when busy #3745

merged 3 commits into from
Jan 12, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jan 9, 2024 •
edited
Loading

Prevent auto-detection during verify board and backup on flash as it might disturb other processes.

Excluded is to make the button smarter as it does have lot's of events

enable autodetect when

  • initialize tab
  • new port is detected
  • board is switched and was not same target
  • abort flashing after flash firmware is cancelled

disable autodetect when

  • in DFU mode
  • board is switched and was same target
  • using autodetect to verify board (which triggers port change)
  • using backup on flash (which also triggers port change)
  • load firmware

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jan 9, 2024
@haslinghuis haslinghuis self-assigned this Jan 9, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Jan 9, 2024 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@nerdCopter

This comment was marked as outdated.

Sign in to view
@haslinghuis haslinghuis marked this pull request as draft January 9, 2024 14:20
@haslinghuis haslinghuis force-pushed the fix-intermittent-port-failure branch from cb3f7e8 to d20b202 Compare January 10, 2024 00:21
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the fix-intermittent-port-failure branch 3 times, most recently from 3ebc071 to 8c8a1d7 Compare January 10, 2024 00:38
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@nerdCopter
Copy link
Member

nerdCopter commented Jan 10, 2024 •
edited
Loading

  • working pretty good. seemingly better than master, but not too deeply tested.
  • flashed 2 different FC a few times with a few different defines.
  • autodetect working well when swapping plugged FC's.
  • skips for DFU mode as expected.
  • skips autodetect on same FC as expected.

gui.log.txt

@haslinghuis haslinghuis force-pushed the fix-intermittent-port-failure branch from 8c8a1d7 to 5fa4247 Compare January 10, 2024 21:36
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the fix-intermittent-port-failure branch from 03c4d5b to 4046533 Compare January 11, 2024 21:35
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the fix-intermittent-port-failure branch from 4046533 to e09d787 Compare January 11, 2024 22:07
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis changed the title Fix serial Prevent detection when busy Jan 11, 2024
@haslinghuis haslinghuis marked this pull request as ready for review January 11, 2024 22:53
@nerdCopter
Copy link
Member

e09d7872

  • does not auto-detect if FC is plugged before launching configurator (maybe by design & not a problem for me).
  • auto-detects upon FC plugin.
  • skips auto-detect for same FC replug.
  • auto-detects upon different FC plugin.
  • flashing works.

it's really good. impressive improvements.

@haslinghuis haslinghuis merged commit 97a1b62 into betaflight:master Jan 12, 2024
8 checks passed
@haslinghuis haslinghuis deleted the fix-intermittent-port-failure branch January 12, 2024 17:46
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Prevent detection when busy (betaflight#3745)
91714c6 
* Fix serial

* Reset button when loading new firmware

* Some cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@chmelevskij chmelevskij chmelevskij approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@blckmn blckmn Awaiting requested review from blckmn

@asizon asizon Awaiting requested review from asizon

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @blckmn @nerdCopter @chmelevskij