Hide telemetry protocols for CRSF, FPORT and GHST

[haslinghuis]

Inspired after watching https://youtu.be/FMbBfef_R-g

[blckmn]

AUTOMERGE: (FAIL)

• github identifies PR as mergeable -> FAIL
• assigned to a milestone -> PASS
• cooling off period lapsed -> PASS
• commit count less or equal to three -> PASS
• Don't merge label NOT found -> PASS
• at least one RN: label found -> PASS
• Tested label found -> FAIL
• assigned to an approver -> PASS
• approver count at least three -> FAIL

[nerdCopter]

i am not sure i understand here. when i flash either a cloud-build or a non cloud-build 4.5 or 4.4, i already do not see these telemetry-protocols in master, or am i mistaken somehow.

[haslinghuis]

This PR hides the telemetry protocol header and input if CRSF, FPORT or GHST are selected here

[nerdCopter]

i see now,

i thought it was the individual options, but it is the field/header as you explained.

[ctzsnooze]

Yes, this has always been confusing.

I would have preferred that when CRSF was selected, the telemetry protocol would show CRSF, and not be editable.

That's the situation; telemetry is an automative part of CRSF; we do not require any extra setting to enable it, it's always there. So a nicer display element would indicate that it was present and active - because it is.

Same for any Radio protocol that automatically enables telemetry when selected.

[KarateBrot]

We should also make sure to forcefully deselect all selections in that telemetry dropdown before hiding it. (Unless you are already doing that and I can't see it 😃)

[nerdCopter]

• re-approving for new ....select2('destroy');

[haslinghuis]

Unfortunate this does not work. It works when empty but want to keep the [None] option.
Need to find a way to select2() the [None] option. Another issue when using [None] as place holder we cannot unselect the telemetry protocol when using SBUS for example.

[nerdCopter]

after testing, it looked different today as well
CRSF selected:

SBUS selected:

[haslinghuis]

All sorted.

[nerdCopter]

🚀

[nerdCopter]

there is a bug. to reproduce:

1. select IBUS,
2. select IBUS EXTENDED,
3. select CRSF,
4. select IBUS,
5. select IBUS EXTENDED -- it will set to None.

same for other protocols. they are removed, but not return when protocol is changed.

[nerdCopter]

d880010b seems to work proper.

edit: check SonarCloud

[ctzsnooze]

Could I see a screenshot of how it looks now when the telemetry is 'included', ie when user selects CSRF? Saying 'automatically included', or similar, in the box to the right, kind of works for me, so long as those words don't appear in the drop-down. And I guess if it is 'included' then we don't need the drop-down to be available?

[nerdCopter]

• screenshot in description @ctzsnooze .
• Currently says "This Radio Protocol has Telemetry included", but i think "Automatically Included" is fair as well.

[haslinghuis]

Drop down is not available when telemetry is included. Updated screen shot.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

[ctzsnooze]

Thanks! This looks really good. Very much like to see "automatically included", much nicer than before.