Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify GPS Signal Strength #3705

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 29, 2023

Only show GPS Signal Strength when GPS is active.

Currently when having SatInfo and powering off the GPS configurator only shows last frozen state.

Resetting data won't show values - we can show an informational message like:

image

UPDATE:

image

EDIT:

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Dec 29, 2023
@haslinghuis haslinghuis self-assigned this Dec 29, 2023

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Dec 29, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis modified the milestones: 10.10.0, 11.0 Dec 30, 2023
@nerdCopter
Copy link
Member

Would it make more sense to re-initialize the values upon disconnect or GPS-not-powered state?

Copy link

sonarcloud bot commented Dec 31, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

This comment has been minimized.

@nerdCopter
Copy link
Member

nerdCopter commented Jan 4, 2024

looks good, but i have no real GPS to test.

@haslinghuis
Copy link
Member Author

haslinghuis commented Jan 4, 2024

Do not want to make it to complicated. Thinking about it perhaps we should have a second message - but requires keeping state.

  1. At startup when no signal data has been received as GNSS has not been detected yet we show the message above.
  2. When loosing signal after being detected we show a message like
The GNSS unit is no longer recognized.

@ctzsnooze
Copy link
Member

This should probably be a 4.6 new feature. It is an improvement but could introduce unexpected issues, and will require testing that would delay 4.5.

@haslinghuis haslinghuis modified the milestones: 10.10.0, 11.0 Jan 5, 2024
@ctzsnooze
Copy link
Member

Hi Mark... checking this now - does it need rebasing? Seems to work, when I test it, and the message is useful.

Perhaps the text could say:

Connecting...
The GPS icon lights up when Betaflight is connected to a GPS module.  This usually takes a couple of seconds.<br>
It will be red at first, then change to yellow when it gets a 3D fix.<br>
If the GPS icon does not light up, check your wiring and configuration, and confirm that the GPS module is receiving power.<br>
The CLI "status" command provides more information about the state of the GPS connection.

That last line is optional and perhaps unnecessary, whatever you think.

@haslinghuis haslinghuis force-pushed the toggle-signal-strenght branch from be3a074 to 9383beb Compare April 4, 2024 10:27
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for origin-betaflight-configurator ready!

Name Link
🔨 Latest commit b6f6b79
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-configurator/deploys/6616852dbc6f7b0008e10521
😎 Deploy Preview https://deploy-preview-3705--origin-betaflight-configurator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@haslinghuis haslinghuis force-pushed the toggle-signal-strenght branch from 63ae6df to c029566 Compare April 6, 2024 23:37

This comment has been minimized.

@haslinghuis haslinghuis force-pushed the toggle-signal-strenght branch from c029566 to 1cd352e Compare April 7, 2024 00:03

This comment has been minimized.

@haslinghuis haslinghuis modified the milestones: 11.0, 10.10.0 Apr 9, 2024
@haslinghuis haslinghuis changed the title Hide GPS Signal Strength if GPS is not active Clarify GPS Signal Strength and show DOP in GUI. Apr 9, 2024
@haslinghuis haslinghuis force-pushed the toggle-signal-strenght branch from 1cd352e to ab2a36d Compare April 9, 2024 22:19

This comment has been minimized.

@haslinghuis haslinghuis changed the title Clarify GPS Signal Strength and show DOP in GUI. Clarify GPS Signal Strength Apr 9, 2024
@haslinghuis
Copy link
Member Author

Rebased on master

@ctzsnooze
Copy link
Member

ctzsnooze commented Apr 10, 2024

Just checking the PR again...
There is a bit of pale grey space under the 'yellow' of the 'Connecting...' note - maybe that can be removed?
Screen Shot 2024-04-10 at 12 44 47 pm

@ctzsnooze
Copy link
Member

Also, I wonder if some tiny simplifications, and wider line spacing, may improve readability:

The GPS icon lights up only when the connection to the GPS module is confirmed.<br>
<br>
It will be red at first, changing to yellow when the 3D fix is attained.<br>
<br>
If the GPS icon does not light up, check your wiring and configuration, and confirm that the GPS module is receiving power.<br>
<br>
The CLI 'status' command provides more information about the state of the GPS connection.

Copy link
Member

@HThuren HThuren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the last more simple message, and for sure the idea.

@haslinghuis haslinghuis force-pushed the toggle-signal-strenght branch from ab2a36d to 78cb7ef Compare April 10, 2024 12:23
@haslinghuis haslinghuis force-pushed the toggle-signal-strenght branch from 78cb7ef to b6f6b79 Compare April 10, 2024 12:25
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Linux
Betaflight-Configurator-Android
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit e1f5f24 into betaflight:master Apr 10, 2024
12 checks passed
@haslinghuis haslinghuis deleted the toggle-signal-strenght branch April 10, 2024 13:29
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Hide GPS Signal Strength if GPS is not active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

5 participants