-
-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify GPS Signal Strength #3705
Clarify GPS Signal Strength #3705
Conversation
This comment has been minimized.
This comment has been minimized.
AUTOMERGE: (FAIL)
|
Would it make more sense to re-initialize the values upon disconnect or GPS-not-powered state? |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
This comment has been minimized.
This comment has been minimized.
looks good, but i have no real GPS to test. |
Do not want to make it to complicated. Thinking about it perhaps we should have a second message - but requires keeping state.
|
This should probably be a 4.6 new feature. It is an improvement but could introduce unexpected issues, and will require testing that would delay 4.5. |
Hi Mark... checking this now - does it need rebasing? Seems to work, when I test it, and the message is useful. Perhaps the text could say:
That last line is optional and perhaps unnecessary, whatever you think. |
be3a074
to
9383beb
Compare
✅ Deploy Preview for origin-betaflight-configurator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e4012ca
to
63ae6df
Compare
This comment has been minimized.
This comment has been minimized.
63ae6df
to
c029566
Compare
This comment has been minimized.
This comment has been minimized.
c029566
to
1cd352e
Compare
This comment has been minimized.
This comment has been minimized.
1cd352e
to
ab2a36d
Compare
This comment has been minimized.
This comment has been minimized.
Rebased on master |
Also, I wonder if some tiny simplifications, and wider line spacing, may improve readability:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the last more simple message, and for sure the idea.
ab2a36d
to
78cb7ef
Compare
78cb7ef
to
b6f6b79
Compare
Quality Gate passedIssues Measures |
Do you want to test this code? Here you have an automated build: |
Hide GPS Signal Strength if GPS is not active
Only show GPS Signal Strength when GPS is active.
Currently when having SatInfo and powering off the GPS configurator only shows last frozen state.
Resetting data won't show values - we can show an informational message like:
UPDATE:
EDIT: