Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append craftname #3637

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Append craftname #3637

merged 2 commits into from
Nov 18, 2023

Conversation

haslinghuis
Copy link
Member

Fixes #3636

@haslinghuis haslinghuis added this to the 10.10.0 milestone Nov 17, 2023
@haslinghuis haslinghuis self-assigned this Nov 17, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
nerdCopter
nerdCopter approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • tested successfully.
  • love it
    image

@blckmn
Copy link
Member

blckmn commented Nov 17, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@PacificTrade
Copy link

PacificTrade commented Nov 17, 2023 •
edited
Loading

Previously craft name was before date_time. Is there some reason why it shouldn't go back to that? Made it easy to sort by name
image

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis changed the title Append craftname to filename Insert craftname into filename Nov 17, 2023
@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis changed the title Insert craftname into filename Append craftname Nov 17, 2023
@PacificTrade
Copy link

image
Perfect! Came on here a few hours ago expecting to post an issue and it's already fixed. You guys are too fast.

@haslinghuis haslinghuis merged commit f0fc111 into betaflight:master Nov 18, 2023
9 checks passed
@haslinghuis haslinghuis deleted the append-craftname branch November 18, 2023 10:10
@pitts-mo pitts-mo mentioned this pull request Dec 31, 2023
Closed
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Append craftname (betaflight#3637)
2ea3d02 
* Append craftname to filename

* Reorder craftname for better sort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@McGiverGim McGiverGim McGiverGim approved these changes

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

@asizon asizon Awaiting requested review from asizon

Assignees

@haslinghuis haslinghuis

Labels
RN: IMPROVEMENT Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

re-implement craft_name within output file names (as option?)
5 participants
@haslinghuis @blckmn @PacificTrade @McGiverGim @nerdCopter