Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug field names in sensor tab #3587

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Add debug field names in sensor tab #3587

merged 3 commits into from
Sep 20, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Sep 18, 2023 •
edited
Loading

  1. Add debug field names to sensor tab
  2. Refactor blackbox data fields to be maintained in one file only.
  3. Add missing RC_STATS debug mode and fix unknown field names.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Sep 18, 2023
@haslinghuis haslinghuis self-assigned this Sep 18, 2023
@github-actions

This comment has been minimized.

Sign in to view
nerdCopter
nerdCopter approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Sep 18, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@github-actions

This comment has been minimized.

Sign in to view
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
80.5% 80.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis changed the title Add debug columns Add debug field names in sensor tab Sep 19, 2023
@HThuren
Copy link
Member

HThuren commented Sep 20, 2023

nice work

@haslinghuis haslinghuis merged commit feae937 into betaflight:master Sep 20, 2023
8 of 9 checks passed
@haslinghuis haslinghuis deleted the add-debug-columns branch September 20, 2023 08:02
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Add debug field names in sensor tab (betaflight#3587)
9661944 
* Add debug columns

* Refactor debug

* Add missing debug mode and fix unknown category
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@chmelevskij chmelevskij chmelevskij approved these changes

@ctzsnooze ctzsnooze Awaiting requested review from ctzsnooze

@blckmn blckmn Awaiting requested review from blckmn

Assignees

@haslinghuis haslinghuis

Labels
RN: IMPROVEMENT
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@haslinghuis @blckmn @HThuren @chmelevskij @nerdCopter